Community
Participate
Working Groups
Build ID: Eclipse 3.4M6a Steps To Reproduce: The items inside of DetailedProgressViewer use "FormLayout" to do it's layout. Because of that, there are some UI issues. I believe that "GridLayout" would be more appropriate. 1) When an item doesn't have a ProgressIndicator, the label text flows into the ToolItem and overlaps it. 2) I think it would look better if items without images would have their label text vertically aligned with the text of items with images. 3) I think having the same height for all the items (those with indicator and without) would look better. Layout would also be faster to calculate. See attachments...
Created attachment 97975 [details] UI capture
Created attachment 98634 [details] patch Reworked DetailedProgressViewer and ProgressInfoItem to use GridLayout. Flicker was also removed by using setRedraw() on the controls when doing multiple updates at a time. A Resize listener was added that will re-layout the label text (and shorten it) when resize events occur.
Any chance on accepting this patch for 3.5?
This bug has an attached patch.
Sorry. Its too late for 3.5 I'll look into 3.6
(In reply to comment #3) > Any chance on accepting this patch for 3.5? > Min, The patch is little outdated. It would be great if you could respin the patch for the latest code.
Sure. I'll try to get to it when I can. BTW, I have plans for reworking the viewer even more extensively. Right now, when new jobs pop up that are sorted ahead of existing Jobs, the progress bar widget is disposed and recreated in the new spot. This leads to flickr, and loss of the progress position for "unknown" progress monitors. Better would be to have a model of each individual progress. Instead of destroying/recreating the status widgets, a widget could just "adapt" to the model that tracks the progress.
Created attachment 146644 [details] Patch v01 (In reply to comment #0) > The items inside of DetailedProgressViewer use "FormLayout" to do it's layout. > Because of that, there are some UI issues. > > I believe that "GridLayout" would be more appropriate. > > 1) When an item doesn't have a ProgressIndicator, the label text flows into the > ToolItem and overlaps it. > 2) I think it would look better if items without images would have their label > text vertically aligned with the text of items with images. > 3) I think having the same height for all the items (those with indicator and > without) would look better. Layout would also be faster to calculate. I tried to look into this. It seems like FormLayout is more appropriate than GridLayout. 1) The patch fixes it 2) That would look nice if all the jobs have 16x16 icons. But there is no constraint on the image size and the user is allowed to have any sized icon. In this case, it would not look nice, if all the progress bars are aligned to the biggest icon in the view 3) Height of the items cannot be same for the same reason above The attached patch additionally center aligns the job image vertically
Patch v01 released to HEAD
(In reply to comment #0) > 2) I think it would look better if items without images would have their label > text vertically aligned with the text of items with images. I filed bug 289239 for another way to fix this.
Verified in I20090914-1800
There are still some issues. Instead of re-opening this bug, I've created bug 293877.
