Description Adam Cabler 2008-04-28 19:55:18 EDT

Build ID: I20080330-1350

I have a console pattern matcher with a IHyperlink.  Left clicking on a hyperlink in the console behaves as expected.  However, when I right click on a  hyperlink created and select "Open Link" nothing happens.  This is because the TextConsoleViewer receives a mouseExit call which in turn calls linkExited on the selected hyperlink before the hyperlink is activated.  Next the enablement of the action is checked and since TextConsoleViewer set the link to null, the action is not executed.

To fix this, I suggest populating FollowHyperlinkAction with the hyperlink to activate at creation.  The enablement could then be hyperlink != null.

FollowHyperLinkAction.java:
public class FollowHyperlinkAction extends Action {

	private TextConsoleViewer viewer;
        private IHyperLink hyperlink;

    /**
	 * Constructs a follow link action
	 */
	public FollowHyperlinkAction(TextConsoleViewer consoleViewer) {
	    super(ConsoleMessages.FollowHyperlinkAction_0); 
		setToolTipText(ConsoleMessages.FollowHyperlinkAction_1); 
		PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IConsoleHelpContextIds.CONSOLE_OPEN_LINK_ACTION);
		this.viewer = consoleViewer;
                this.hyperlink = consoleViewer.getHyperLink();
	}

    /* (non-Javadoc)
     * @see org.eclipse.jface.action.IAction#isEnabled()
     */
    public boolean isEnabled() {
        return hyperlink != null;
    }
	
    /*
     *  (non-Javadoc)
     * @see org.eclipse.jface.action.IAction#run()
     */
	public void run() {
		if (hyperlink != null) {
			hyperlink .linkActivated();
		}
	}

}