Bug 228857 - Do not use (s) in Apply Patch
Summary: Do not use (s) in Apply Patch
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-25 06:55 EDT by Dani Megert CLA
Modified: 2008-04-30 05:15 EDT (History)
0 users

See Also:

Attachments
"line(s)" replaced with "lines" (1.05 KB, patch)
2008-04-25 07:31 EDT, Tomasz Zarna CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-04-25 06:55:27 EDT 
HEAD of 20080425-0800.

The Apply Patch shows:
"Patch contains x added and y removed line(s)."

Using "(s)" is a UI blooper. The message should use the correct form i.e. singular or plural style. I guess in your case you could simply use plural as

"Patch contains 0 added and 0 removed lines."

sounds correct to my non-native English ear.

Please check other strings as well.
Comment 1 Tomasz Zarna CLA 2008-04-25 07:31:10 EDT 
Created attachment 97594 [details]
"line(s)" replaced with "lines"
Comment 2 Tomasz Zarna CLA 2008-04-25 07:52:39 EDT 
There is 12 more (s) in Compare/Team/CVS components. I will open a separate bug(s) ;) for them with the same justification you gave in comment 0. Thanks for pointing this out, Dani.
Comment 3 Tomasz Zarna CLA 2008-04-25 08:31:56 EDT 
Patch released but bug 228865 opened.
Comment 4 Tomasz Zarna CLA 2008-04-30 05:15:33 EDT 
Verified in I20080429-0100.