Bug 228207 - [Themes] HC theme should compute defaults into JFace
Summary: [Themes] HC theme should compute defaults into JFace
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-22 10:33 EDT by Kevin McGuire CLA
Modified: 2019-09-06 15:38 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2008-04-22 10:33:59 EDT 
Bug #205474 had a temporary fix to ensure that HC fonts still worked.
Prior to the original fix for bug #205474 HC worked.  The new fix puts the old code back but just for the HC case.

A better solution is that the HC theme should compute the correct values and set them as defaults into the JFace registry.  Presently the HC theme has empty <fontOverrides>.  These clearly rely on default behaviour elsewhere.  Instead, we should consider settings values in the fontOverride such as keywords for _system_text_font_ or _system_banner_font which we then compute the correct values and store as defaults into the JFace registry.
Comment 1 Boris Bokowski CLA 2009-05-06 16:49:21 EDT 
Removing 3.5 target milestone. We are in the end-game now. Please have a look and decide if this should be targeted at 3.6.
Comment 2 Boris Bokowski CLA 2009-11-17 11:34:04 EST 
Susan is now responsible for watching the [Themes] category.
Comment 3 Eclipse Webmaster CLA 2019-09-06 15:38:18 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.