Community
Participate
Working Groups
The eu.geclipse.info plug-in has dependencies to the UI. I think it would be reasonable to separate the UI parts from the core parts as we did with all other plug-ins. Therefore I vote for moving the UI stuff into a new plug-in eu.geclipse.info.ui. Would that cause problems? Any objections?
Just having a deeper look into this and it turns out that a lot of plug-ins are using eu.geclipse.info for the core functionalities and "accidentally" get the UI dependency from that, e.g. eu.geclipse.voms or eu.geclipse.gria (see the reverse dependencies on our build page for reference). So therefore I strongly vote for separating the UI parts!
I am on it. I have removed the org.eclipse.ui dependency from eu.geclipse.info and I created a eu.geclipse.info.ui plugin. Since I am leaving on Wednesday for my easter vacation I will commit it in a couple of weeks.
Well, there is only _one_ class in glite.info which depends on UI stuff, namely GLiteInfoViewerFilter (and the corresponding extension point data). So i think that one should go to eu.geclipse.glite.ui when this plugin is ready, no need to add a new e.g.glite.info.ui plugin.
Hi Nick, sorry for my missplaced comment, actually eu.geclipse.glite.info also has a UI dependency, submitted as a separate bug. Mathias, wouldn't make sense to rename eu.geclipse.info ---> eu.geclipse.core.info and move the UI parts of e.g.info (which are just the 3/4 classes for the GlueInfoViewer) into eu.geclipse.ui, instead of creating yet another plugin?
BTW, eu.geclipse.ui _already_ depends on eu.geclipse.info, so we should definitely rename info -> core.info i think
I do not think we should rename it to eu.geclipse.core.info. The reason for that is that it contains the GLUE schema which is somehow a "third party functionality". Therefore it is somehow comparable with the eu.geclipse.jsdl plug-in which we should also not rename to eu.geclipse.core.jsdl. For me core is always ONLY g-Eclipse's own definitions and functionalities. As a consequence I would therefore also vote for moving the UI stuff to a separate plug-in, i.e. eu.geclipse.info.ui.
It makes sense that reasoning. But notice that currently e.g.core depends on e.g.jsdl !! so it is somehow inconsistent anyways... those "dependencies" should rather come via extension points. Actually it is quite a matter of taste, we have to have a policy and follow it. I thought you wanted e.g.ui to contain the UI code for all core components (core.*) and only those. e.g.info is currently the only exception there. And it even contains classes called GridGlue*Source. UI depends on just a few classes from .info (GridGlueService, ..Computing, ..Storage) but i do not see how to easily separate that. And in this case an extension point doesn't make sense (for JSDL it does because we have already 3 or 4 different JobDescription implementations)
I have create a new ui plugin eu.geclipse.info.ui. The following patches also do the following things: * Info system queries all the registry instances that are available for a user in a specific registry service (hard coded so far) * Info system displays the different registry instances under the info services tree in grid project view in the format [registry instance name] registry @ host as described in bug 226485.
Created attachment 98609 [details] Patch for eu.geclipse.glite.info
Created attachment 98610 [details] Patch for eu.geclipse.gria.info.test
Created attachment 98611 [details] Patch for eu.geclipse.gria.info
Created attachment 98612 [details] Patch for eu.geclipse.info
Created attachment 98613 [details] The new pluging eu.geclipse.info.ui It is in .rar file
Patches applied
I have created a new plugin eu.geclipse.info.ui. Please check it and close it if everything is fine.
Closing
Comment on attachment 98609 [details] Patch for eu.geclipse.glite.info Applied by Harald G
Comment on attachment 98610 [details] Patch for eu.geclipse.gria.info.test Applied by Harald G
Comment on attachment 98611 [details] Patch for eu.geclipse.gria.info Applied by Harald G
Comment on attachment 98612 [details] Patch for eu.geclipse.info Applied by Harald G
Comment on attachment 98613 [details] The new pluging eu.geclipse.info.ui Applied by Harald G
