Bug 2281 - Undoing all changes does not revert file to "unchanged" state (1GEK1OY)
Summary: Undoing all changes does not revert file to "unchanged" state (1GEK1OY)
Status: RESOLVED DUPLICATE of bug 21493
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 2000
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
: 7198 12926 16236 20516 21157 22022 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-10 22:33 EDT by Kevin Haaland CLA
Modified: 2004-09-15 11:08 EDT (History)
11 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Haaland CLA 2001-10-10 22:33:09 EDT
To see the problem:
	Double-click on a resource to open an editor.
	Make some changes.
	Undo all the changes.
	Note that the '*' still appears by the name of the file in the editor tab, and that
		the Save button has not been greyed out.

	Many text editors provide visual confirmation that all unsaved changes have been
	undone by restoring whatever visual cues onscreen it uses to show that a file has been
	saved.  This makes the current behaviour somewhat counter-intuitive by comparison.

	JB (30/05/2001 4:01:03 PM)

NOTES:
Comment 1 DJ Houghton CLA 2001-10-29 18:04:49 EST
PRODUCT VERSION:
	Build 113

Comment 2 Paula Cox (WSAD) CLA 2002-01-11 00:35:26 EST
Problem still exists in the 12/4/2001 Driver, and has been reported by one of 
our key customers.
Comment 3 Kevin Haaland CLA 2002-01-21 21:39:45 EST
Kai,

   Pls check in latest 2.0 builds. 
Comment 4 Jane Fung CLA 2002-04-05 16:44:09 EST
problem still exists in 20020214 and 20020321 build
Comment 5 Kai-Uwe Maetzel CLA 2002-05-02 05:24:40 EDT
Post 2.0
Comment 6 Jared Burns CLA 2002-05-17 11:13:12 EDT
*** Bug 7198 has been marked as a duplicate of this bug. ***
Comment 7 Jared Burns CLA 2002-05-17 11:13:59 EDT
*** Bug 16236 has been marked as a duplicate of this bug. ***
Comment 8 Nick Edgar CLA 2002-06-18 13:03:14 EDT
*** Bug 12926 has been marked as a duplicate of this bug. ***
Comment 9 Nick Edgar CLA 2002-06-18 13:03:30 EDT
*** Bug 20516 has been marked as a duplicate of this bug. ***
Comment 10 Nick Edgar CLA 2002-07-04 14:20:26 EDT
*** Bug 21157 has been marked as a duplicate of this bug. ***
Comment 11 Nick Edgar CLA 2002-07-30 11:35:59 EDT
*** Bug 22022 has been marked as a duplicate of this bug. ***
Comment 12 Matthew Conway CLA 2003-04-11 11:01:13 EDT
Is anything going to be done for this bug?
It was marked as later for 2.0, and here we are post 2.1 - just don't want it to
fall through the cracks...
Comment 13 Johan Compagner CLA 2003-04-11 11:04:21 EDT
yes please do something about this.. it is very annoying..

I tried it myself to change the code. But the dirty state is of a Editor is 
completely separated from the Undo/Redo mechanism.. as far as i could see.
Comment 14 Jeff Turnham CLA 2003-08-25 12:06:26 EDT
Now that we are well past 2.0, should this bug be re-opened?
Comment 15 Tim Koss CLA 2003-10-20 12:59:23 EDT
Deferred for 3.0.
Comment 16 Matthew Conway CLA 2004-05-13 18:30:06 EDT
Is this going to be done for 3.0?

This bug has been around since time immemorial - how hard could it be to fix?
It is EXTREMELY annoying to have to close/reopen an editor just to get rid of an
accidental edit, especially with all the prompting eclipse does when a buffer is
dirty and you try to do anything.

Every other substantial editor out there has this capability, and I'm sure I
couldn't be the only one that this annoys so much.

Is it just falling through the cracks because it is marked as resolved?  If do,
please reopen it - I really would like this to be in 3.0


Comment 17 Johan Compagner CLA 2004-05-13 18:40:45 EDT
yes please reopen this asap.
this is long time a quite annoying thing. I already looked at the code for this 
but the undo/redo support is in a completely different portion of the code then 
the state of the editor (at least that's the way it looked to me quite some 
time ago when i looked at it)
Comment 18 Michael Van Meekeren CLA 2004-06-18 14:27:59 EDT
reopening
Comment 19 Michael Van Meekeren CLA 2004-06-18 14:28:39 EDT
oops... undoing last change
Comment 20 Matthew Conway CLA 2004-06-18 14:34:59 EDT
Hey, are you trying to pull a fast one here? ;-)
As of 200406180800, this is most assuredly NOT fixed, so maybe you meant to
change the status to something else?

Comment 21 Randy Hudson CLA 2004-06-18 14:57:39 EDT
moving back to LATER :-(
Comment 22 Randy Hudson CLA 2004-06-18 14:58:01 EDT
MVM was here ;-)
Comment 23 Matthew Conway CLA 2004-06-18 15:30:20 EDT
Just a thought on implementing this:
Since QuickDiff(Revision on Disk) seems to be able to tell if an editor is clean
(diff list is empty), why not just reuse that functionality to set the buffer's
dirty flag after an undo operation?

Comment 24 Leopold Welsch CLA 2004-09-13 07:57:19 EDT
Will there anything be done on this issue? It is a really annoying one.
Comment 25 Randy Hudson CLA 2004-09-13 10:35:33 EDT
You don't enjoy right-clicking and selecting "Revert" 10 times a day?  That's 
odd :-)
Comment 26 Leopold Welsch CLA 2004-09-14 09:26:06 EDT
Meehn, that's odd. Although there is the information about this available, it is
not used at all. 
Comment 27 Matthew Conway CLA 2004-09-14 13:38:08 EDT
Is this bug being ignored because it is marked Resolved?
If no one says otherwise, I'll assume that is the case and create a new bug.
Comment 28 Randy Hudson CLA 2004-09-14 13:52:32 EDT
reopening for 3.1
Comment 29 Matthew Conway CLA 2004-09-14 14:22:50 EDT
/me does a little dance =)

Comment 30 Leopold Welsch CLA 2004-09-15 03:35:12 EDT
For the next 3 years, or 36 months or 1071 days (and more)???
Comment 31 Kai-Uwe Maetzel CLA 2004-09-15 11:08:07 EDT

*** This bug has been marked as a duplicate of 21493 ***