Bug 227982 - Open Resource dialog should support colored labels
Summary: Open Resource dialog should support colored labels
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, polish
Depends on:
Blocks:
 
Reported: 2008-04-21 06:23 EDT by Markus Keller CLA
Modified: 2008-05-30 22:18 EDT (History)
3 users (show)

See Also:

Attachments
patch (5.17 KB, patch)
2008-05-07 04:04 EDT, Martin Aeschlimann CLA 		no flags Details | Diff
patch that also fixes the flickering (6.00 KB, patch)
2008-05-07 04:12 EDT, Martin Aeschlimann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-04-21 06:23:15 EDT 
I20080415-1646

Open Resource dialog should support colored labels.
Comment 1 Eric Moffatt CLA 2008-04-21 16:01:20 EDT 
Ooops, and then back to me since I own it...;-). I'd still like your input though.
Comment 2 Eric Moffatt CLA 2008-04-21 16:03:15 EDT 
Wrong bug...that's two 'ooops' and we haven't even worked on it yet...;-)
Comment 3 Eric Moffatt CLA 2008-04-21 16:39:32 EDT 
Boris, for you ?
Comment 4 Boris Bokowski CLA 2008-04-21 17:10:14 EDT 
Polish?
Comment 5 Boris Bokowski CLA 2008-05-06 16:53:22 EDT 
It doesn't look like I will have time for this.
Comment 6 Martin Aeschlimann CLA 2008-05-07 04:04:08 EDT 
Created attachment 99013 [details]
patch

Adds colors to the labels.
Comment 7 Martin Aeschlimann CLA 2008-05-07 04:12:13 EDT 
Created attachment 99015 [details]
patch that also fixes the flickering

This patch also fixes the flickering from the CVS decorators (bug 175507), by removing the decorations.

- The flickering is really bad (use cursors to change selection...)
- I don't think it's important to show the lightweight decorators here . We don't show them in the Open Type dialog.
- Correctly fixing the flickering would be a bigger change, probably with API changes: The label provider needs to become a IViewerLabelProvider or a CellLabelProvider so it can implement 'update' and decide if a label is ready to be shown. 

I would suggest to release this patch for 3.4.
Comment 8 Boris Bokowski CLA 2008-05-07 08:59:51 EDT 
Back on the candidate list for RC1. Thanks Martin! :-)
Comment 9 Boris Bokowski CLA 2008-05-08 17:15:20 EDT 
Released to HEAD.
Comment 10 Boris Bokowski CLA 2008-05-30 22:18:37 EDT 
Verified on Windows XP using I20080530-1730.