Bug 227757 - [Viewers] Move MultiLabelDecorator to JFace.
Summary: [Viewers] Move MultiLabelDecorator to JFace.
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-04-18 08:38 EDT by Ketan Padegaonkar CLA
Modified: 2019-09-06 16:09 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ketan Padegaonkar CLA 2008-04-18 08:38:59 EDT
Build ID: 3.4M6a

Steps To Reproduce:
MultiLabelDecorator is a useful piece of code that's useful to apply a series of decorators on a label provider.

Unfortunately this is sitting inside the team internal API, requesting that this be moved to jface.

The usecase in my case happens to be that I'm subclassing the resource view that shows some specific resources.


More information:
Comment 1 Tomasz Zarna CLA 2008-06-20 11:35:08 EDT
I'm fine with it, but I think you should ask the UI team first, if they would accept this beautiful piece of code. Putting Eric on CC since he's triaging the UI box at the moment.
Comment 2 Eric Moffatt CLA 2008-06-23 11:14:48 EDT
Tomasz, I haven't looked at the code...is it 'clean' in the sense that it doesn't have internal dependencies? Does it use the JFace ResourceManager ?

I don't see a big issue with adopting it but then again I'm not the person that'd be responsible for maintaining it so that's easy for me to say..;-).

I'll add Boris for comment (warning, he's off for a few weeks so it make take a bit to get am answer...;-).

Comment 3 Ketan Padegaonkar CLA 2008-08-29 08:55:56 EDT
Can this be fixed for 3.5M1 ?
Comment 4 Ketan Padegaonkar CLA 2008-10-30 11:57:19 EDT
Is there something stopping this from being fixed ? 

The only classes/interfaces that are used in MultiLabelDecorator are:

 org.eclipse.jface.viewers.IColorDecorator;
 org.eclipse.jface.viewers.IFontDecorator;
 org.eclipse.jface.viewers.ILabelDecorator;
 org.eclipse.jface.viewers.LabelProvider;
 org.eclipse.swt.graphics.Color;
 org.eclipse.swt.graphics.Font;
 org.eclipse.swt.graphics.Image;

I do not see any dependencies on either the team api or the resource manager.
Comment 5 Boris Bokowski CLA 2008-10-30 12:18:51 EDT
Ketan, would you be able to attach a patch? I cannot promise anything, but a patch would help me, in particular if it included test cases. (Does Team have any tests for this?)

See also http://wiki.eclipse.org/Platform_UI/How_to_Contribute
Comment 6 Thomas Schindl CLA 2008-10-30 12:23:15 EDT
I know this could be a helpful class but why add another API. Couldn't we merge those 2 things and provide a (Multi)LabelDecorator on the new JFace-API [bug 182216]?

Yet I don't have time and not enough knowledge about decorator API to finalize what we have in bug 182216.
Comment 7 Boris Bokowski CLA 2009-11-26 09:49:01 EST
Hitesh is now responsible for watching bugs in the [Viewers] component area.
Comment 8 Eclipse Webmaster CLA 2019-09-06 16:09:25 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.