Bug 227284 - Migration: CVS integration uses secure storage
Summary: Migration: CVS integration uses secure storage
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords: Documentation, readme
Depends on:
Blocks:
 
Reported: 2008-04-16 05:07 EDT by Markus Keller CLA
Modified: 2008-12-10 04:44 EST (History)
6 users (show)

See Also:


Attachments
3.4 Migration FAQ updated (1.20 KB, patch)
2008-06-11 07:18 EDT, Tomasz Zarna CLA
no flags Details | Diff
mylyn/context/zip (4.69 KB, application/octet-stream)
2008-06-11 07:18 EDT, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-04-16 05:07:26 EDT
I20080415-1646

Up to last week's build, we started Eclipse with a -keyring <path-to-file> command line argument. This stored all CVS passwords in the file and we were never asked to enter a password any more.

This functionality is completely broken in I20080415-1646. The -keyring argument does not seem to have any effect any more.
Comment 1 Oleg Besedin CLA 2008-04-16 10:35:22 EDT
The CVS integration switched to the secure storage. The secure storage by default is located in the user's home directory. 

The "-keyring" option specifies location of Authorization database that is no longer used by the CVS integration. The data is not migrated automatically as the process of migration would be probably as "hard" as the process of enetering passwords in the new storage. (Of course, there might be cases where people had lots of CVS conenction as opposing to usual one or two or three.)

There are some issues with headless runs, see bug 227298. Until those are resolved (which should be a matter of a day or two), the following runtime options might help:

-eclipse.password <path_to_file>

The <path_to_file> specifiies non-empty file contents of which is treated as a password.

-eclipse.keyring <path_to_file>

Overrides default location of the secure sotrage file (normally something like 
C:\Documents and Settings\user_name\secure_preferences.equinox)

Does this help? I hope it is just a case of being surprised by the switch of CVS to the new underlying storage; in a hindsight, we should have posted a message about it.
Comment 2 Markus Keller CLA 2008-04-16 12:32:58 EDT
> Does this help? I hope it is just a case of being surprised by the switch of
> CVS to the new underlying storage; in a hindsight, we should have posted a
> message about it.

Thanks, the default location is good enough for us for now.

However, you need to mention this breaking change (not supporting -keyring any more) in the migration guide and you should write an explanatory message to the log when -keyring is on the command line.
Comment 3 Oleg Besedin CLA 2008-04-16 16:56:13 EDT
Message send to eclipse-dev.

The "-keyring" remains a valid option as other bundles are likely going to continue to use Auth database, at least for this release. Depending on feedback, we might deprecate "-keyring" & "-password" runtime options in 3.5.

As Tom suggested, we'll need to include some text in the migration guide. Probably something along the lines:
=============
The passwords stored with CVS integration would have to be re-entered as CVS switched to a new secure storage back end. On the plus side, CVS integration now stores passwords in an encrypted form.
=============

Keeping the bug open as a reminder to add this into the migration guide and changing title to better describe the issue.


Comment 4 Dani Megert CLA 2008-04-17 02:45:39 EDT
Oleg, as this affects the users, it would better go into the readme.
Comment 5 Szymon Brandys CLA 2008-04-17 06:16:42 EDT
(In reply to comment #4)
> Oleg, as this affects the users, it would better go into the readme.
> 

I think that the readme/migration guide entry will depend on whether bug 227517 is fixed or not. Oleg is already a volunteer ;-)

Comment 6 Szymon Brandys CLA 2008-05-09 04:23:28 EDT
Mass update - removing 3.4 target. This was one of the bugs marked for
investigation (and potential fixing) in 3.4 but we ran out of time. Please ping
on the bug if fixing it would be really important for 3.4, and does not require
API changes or feature work.
Comment 7 Markus Keller CLA 2008-05-09 04:49:00 EDT
Something needs to be said about this in the readme. Please set an 3.4 milestone.
Comment 8 Szymon Brandys CLA 2008-05-09 04:56:56 EDT
Right. And maybe in the migration guide.
Comment 9 Mike Wilson CLA 2008-06-09 12:02:22 EDT
Did the doc get updated? Reminder to mark fixed or set the target milestone appropriately.
Comment 10 Szymon Brandys CLA 2008-06-10 08:17:05 EDT
This one is not completed. I would like to contribute this doc fix to one of RC4 subsequent builds.
Comment 11 Tomasz Zarna CLA 2008-06-11 07:18:35 EDT
Created attachment 104452 [details]
3.4 Migration FAQ updated
Comment 12 Tomasz Zarna CLA 2008-06-11 07:18:43 EDT
Created attachment 104453 [details]
mylyn/context/zip
Comment 13 Tomasz Zarna CLA 2008-06-11 09:24:00 EDT
Released to HEAD with some minor modifications. Please keep in mind that both "-keyring" and "-password" options are still subject to change (ie might get deprecated in 3.5, see comment 3 from Oleg)
Comment 14 Szymon Brandys CLA 2008-06-16 05:05:12 EDT
We should have updated readme_eclipse.html. 

In the html there is a link to CVS FAQ on wiki.eclipse.org (http://wiki.eclipse.org/index.php/CVS_FAQ). I think we should add there an entry for this issue.
Comment 15 Tomasz Zarna CLA 2008-09-30 06:46:53 EDT
(In reply to comment #14)
> We should have updated readme_eclipse.html.
> 
> In the html there is a link to CVS FAQ on wiki.eclipse.org
> (http://wiki.eclipse.org/index.php/CVS_FAQ). I think we should add there an
> entry for this issue.

Opened bug 249092 for it.