Bug 2266 - [Viewers] POST-RELEASE: Investigate how often label is obtained (1GEGYSS)
Summary: [Viewers] POST-RELEASE: Investigate how often label is obtained (1GEGYSS)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows 98
: P3 normal (vote)
Target Milestone: 2.1 M4   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
: 1878 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-10 22:32 EDT by Nick Edgar CLA
Modified: 2002-12-04 13:31 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Edgar CLA 2001-10-10 22:32:52 EDT 
JA says:

I have noticed while using the version label annotations that getLabel() is called with 
very high frequency in the navigator.  It seems like it might be doing excessive work.  
The VCM label decoration isn't too expensive, but when invoked frequently, it may contribute 
to general loss of responsiveness in the UI.  
For example, just changing the selection in the navigator asks for the labels again.  
Also, during notification phases, getLabel is called frequently.

NOTES:

NE (5/29/01 12:04:37 AM)
Thanks, I'll take a look.  It shouldn't be doing this just when the selection changes, 
unless one of the selection listeners on the viewer is interested.
Actually, it might be the forward/back/up buttons updating their tooltips.  But I'll investigate.
Comment 1 DJ Houghton CLA 2001-10-29 18:03:47 EST 
PRODUCT VERSION:
113
Comment 2 Nick Edgar CLA 2002-01-25 22:31:47 EST 
Tree viewer refreshes are not efficient.  Should revisit.
Comment 3 Nick Edgar CLA 2002-12-04 13:30:17 EST 
Initial viewer population and refresh now only obtain the label at most once.
Please let me know if you see otherwise.
hasChildren can still get called twice, but this is harder to fix.
In the case of VCM, hasChildren should return true if the element -can- 
contain children (i.e. if it represents a folder), and not do the work of 
going to the repository to see if it actually does have children.
Comment 4 Nick Edgar CLA 2002-12-04 13:31:10 EST 
*** Bug 1878 has been marked as a duplicate of this bug. ***