Community
Participate
Working Groups
On MacOS X the Windows look of the AnimatedProgress does not match the Aqua look of the native ProgressBar. So clients using the wrapper ProgressIndicator get either the correct Aqua look or the Windows look (which offends real Mac users :-) BTW: On MacOS X the native ProgressBar already provides the functionality of the AnimatedProgress so on MacOS X the ProgressIndicator could just avoid switching to the AnimatedProgress.
Chris could you look at this on your Powerbook please?
Created attachment 1898 [details] Animated Aqua progressbar
Since Chris is on vacation I've added the picture from Apple's Aqua specification.
On the SWT mailing list Steve agreed to support an INDETERMINED mode in the SWT ProgressBar. When can we expect this?
We have done the investigative hacking on the other platforms and have something running. It's amazing but they all use the native "idle handler" mechanism to do the updating instead of forking a thread inside the control. One further wrinkle is that the native XP progress bar does not update at all when the theme is changed so we will need to run the 98/2000 code in ProgressBar on XP until MS fixes the problem (we can't have a progress bar that doesn't update!). The only remaining thing is to choose (and release) the SWT style constant. On the table are: SWT.INDETERMINATE SWT.INFINITE SWT.CONTINUOUS SWT.ANIMATED I'm leaning towards SWT.ANIMATED because it's a concept that might apply to another widget. SWT.INFINITE is my second choice. The other names are too long. I'm reassigning to SWT and adding VI and SSQ to this discussion so they can give their opinion.
SWT.ANIMATED: +1
SWT .ANIMATED -1 SWT.INDETERMINATE +1 I do not think we should use SWT.ANIMATED because this value might be interesting later on for other things. It is very difficult to assign a value for an SWT constant that does not conflict with other styles (values are re- used for multiple styles since there is a limited number of them). Since we do not know which widgets might in the future be interested in the ANIMATED style, we can not know which styles not to conflict with.
SWT.ANIMATED -1. It is possible to have a representation for indeterminate that is not animated. In fact, I beleive the mac has both 'animated' and 'indeterminate' as independant settings. (i haven't really checked what turning off animated does..). consider platforms that give the user the option to turn off all the fluff.. like watching your window expand when it opens or your popups fade in and out. I see animated representing more along those lines.. SWT.INFINITE -1 . This implies its the progress bar that never ends.. (Which seems true in some cases...) SWT.INDETERMINATE +1. That's exactly what it means. Unless there is a specific restriction on the number of characters, in which I would suggest SWT.DUNNO :)
Assigning to SN. I'm now leaning towards SWT.INFINITE (Chris, it doesn't end) because of VI's and Chris's comments. Chris, the SWT naming rules are to choose the shortest possible names that make sense to avoid typing and scrolling when reading code. We believe that long names actually hurt readability as much as short names. Waiting for "the great" Silenio's opinion and then we will procede.
... that was "too short" names. <g>
SWT.INDETERMINATE +1 I believe this is the only one (out of the four above) that really means what we want. SWT.ANIMATED is good, but as Chris said, there can be animated progress bars that are not "indeterminate". This is the case on Photon (Pt_GAUGE_LIVE and Pt_GAUGE_INDETERMINATE).
SWT.INDETERMINATE it is. Code has been released on Windows and Motif.
Released ProgressBar support for SWT.INDETERMINATE on Mac OS X.
Released INDETERMINATE support on Photon and GTK2.
Changed JFace's ProgressIndicator to support native indeterminate Progress widget. Sent to Tod to commit. As of now, there are no references to SWT custom control AnimatedProgress in the Eclipse source.. Steve, should we deprecate AnimatedProgress?
Yes we should deprecate the class. Veronika? Once that is done, we can close this PR.
We can release this change after the 20021001 build in order that we do not break anyone using the SWT in the 20020924 integration build.
Created attachment 2073 [details] Patch from Chris McLaren
Reassigning to VI. Close after deprecating the old thing.
Deprecated AnimatedProgress.
Patch released for build 20021008
