Bug 226046 - [CommonNavigator] add "Name filter patterns" freetext filter
Summary: [CommonNavigator] add "Name filter patterns" freetext filter
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement with 10 votes (vote)
Target Milestone: 4.11 M3   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL: https://git.eclipse.org/r/25419
Whiteboard:
Keywords: Documentation, noteworthy, usability
Depends on:
Blocks: 427897
  Show dependency tree
 
Reported: 2008-04-07 16:55 EDT by Andrey Loskutov CLA
Modified: 2019-03-29 12:29 EDT (History)
15 users (show)

See Also:


Attachments
The state of the search (35.47 KB, image/png)
2014-04-15 14:14 EDT, Timo Kinnunen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2008-04-07 16:55:41 EDT
According to bug 208693 comment 3:

please add "Name filter patterns" freetext filter to the Project Explorer, as it should be the full featured replacement for the old "legacy" navigator view.

Currently Java Package Explorer view only offers this feature, which is very useful and requested from platform team since 2001 (see bug 1970). Neither old style Navigator view offers a flexible mechanism to hide different files by extension, nor the Common Navigator does that.

The way choosen by Package Explorer view will be a good solution for bug 1970 and will also made the features set requested by bug 208802 complete.
Comment 1 Andrey Loskutov CLA 2009-09-15 02:41:38 EDT
Ping... 3.6?
Comment 2 Mickael Istria CLA 2014-04-15 09:58:05 EDT
@Andrey: What would use think about renaming in Project Explorer > Customize view... dialog, the first tab to "Pre-set filters" and add another tab call "User filters" where user could add some filters and manage them (enable/disable/create/delete) ?
Comment 3 Andrey Loskutov CLA 2014-04-15 10:08:30 EDT
(In reply to Mickael Istria from comment #2)
> @Andrey: What would use think about renaming in Project Explorer > Customize
> view... dialog, the first tab to "Pre-set filters" and add another tab call
> "User filters" where user could add some filters and manage them
> (enable/disable/create/delete) ?

Are you talking about something like "project properties -> resource filters" property page, but for UI only? Can't we reuse the UI somehow? I would appreciate if there will be something like this. Currently for example we would like to hide some project resources from customers, but *do not* hide them from resources API, but this is not that easy...
Comment 4 Mickael Istria CLA 2014-04-15 10:17:21 EDT
(In reply to Andrey Loskutov from comment #3)
> Are you talking about something like "project properties -> resource
> filters" property page, but for UI only?

Not exactly, I'm just thinking about something "from scratch" that would allow to set filters based on name, like JDT package explorer is providing; except that user would be allowed to have several entries and manage them (Package Explorer only offers a single field).
Everything I have in mind is UI only.

> Can't we reuse the UI somehow?

I find the "project properties -> resource filters" quite complicated. I'd like something simpler, a simple viewer with the list of user-defined filters, and ability to update/delete/add some.

> I would appreciate if there will be something like this. Currently for example
> we would like to hide some project resources from customers, but *do not*
> hide them from resources API, but this is not that easy...

You mean as a user or as a plugin provider? Because as a plugin provider, CNF provides efficicent APIs and extension points hide content in project explorer.
Comment 5 Timo Kinnunen CLA 2014-04-15 12:29:13 EDT
(In reply to comment #4)
> I find the "project properties -> resource filters" quite complicated. I'd like
> something simpler, a simple viewer with the list of user-defined filters, and
> ability to update/delete/add some.

I don't know if you're familiar with the plugin, but I love how simple Quick Search is to use: either highlight some text and activate it or activate it and start typing. What I don't like about it is that it's a popup window. I was thinking some pie-in-the-sky ideas on how it could be improved and how about this: 

What if Quick Access worked so that when you start typing into it starts filtering every view that's visible on the screen at the same time! Everything is multi-core these days, so why not. Want to see certain lines in console log? Just type what you want to see. When you find the thing you were looking for just activate its view and the rest of the views go back to the way they were. Quick Access even keeps a list of recently used items, so bouncing between two searches would be just a couple of clicks.
Comment 6 Mickael Istria CLA 2014-04-15 12:35:39 EDT
(In reply to Timo Kinnunen from comment #5)
> What if Quick Access worked so that when you start typing into it starts
> filtering every view that's visible on the screen at the same time!
> Everything is multi-core these days, so why not. Want to see certain lines
> in console log? Just type what you want to see. When you find the thing you
> were looking for just activate its view and the rest of the views go back to
> the way they were. Quick Access even keeps a list of recently used items, so
> bouncing between two searches would be just a couple of clicks.

Although I believe it's certainly a good idea for console (did you open a bug report for that?), I'm not sure how it could apply to project explorer. Indeed, since you'd need to collapse/expand node to check contents, instant feedback doesn't provide the same benefit so obviously.
My goal with this bug is to find somehting that could allow the Project Explorer to replace Package Explorer everywhere (cf bug 427897). A dynamic filtering is for sure a good idea, but it seems way more work than necessary to fulfil my objective.
So IMO, it would be better to track this idea in another report.
Comment 7 Timo Kinnunen CLA 2014-04-15 14:14:55 EDT
Created attachment 242020 [details]
The state of the search

(In reply to comment #6)
> 
> Although I believe it's certainly a good idea for console (did you open a bug
> report for that?), 

No, to do that I would be using Mylyn and staring at the search field in Task List, located almost directly below the Quick Access search field. And Mylyn's Task List isn't the only such example. Please see the attached screenshot for a compilation. No, I won't be opening a bug for searching in console log because I think it would either lead to nothing or it would end up doing more harm than good.

> I'm not sure how it could apply to project explorer. Indeed,
> since you'd need to collapse/expand node to check contents, instant feedback
> doesn't provide the same benefit so obviously.

I was thinking it would look like search results do for a full workspace-wide search, just using Package Explorer's UI conventions. I think it would be quite a good fit, actually.

> My goal with this bug is to find somehting that could allow the Project Explorer
> to replace Package Explorer everywhere (cf bug 427897). A dynamic filtering is
> for sure a good idea, but it seems way more work than necessary to fulfil my
> objective.
> So IMO, it would be better to track this idea in another report.

Agreed, these are pie-in-the-sky ideas and perhaps something to think about while designing UI rather than concrete plans to act upon.
Comment 8 Mickael Istria CLA 2014-04-23 10:17:28 EDT
Suggested a patch allowing user to specify filters on Package Explorer: https://git.eclipse.org/r/25419
Comment 9 Mickael Istria CLA 2014-10-15 06:56:57 EDT
Any chance the suggested patch gets reviewed one day?
Comment 10 Daniel Sokolowski CLA 2015-02-05 00:25:57 EST
This can be accomplished using 'Resource > Resource Filters' BUT this removes items from workspace instead of just simply hiding them which causes plugins such as Force.com IDE to error out as it can not locate 'supporting' meta files.
Comment 11 Mickael Istria CLA 2015-08-21 10:58:36 EDT
@Daniel: Maybe you could review https://git.eclipse.org/r/#/c/25419/ to check whether the suggesdtted implementation please you or whether you have improvement suggestions to make, this might help in getting it merged. and bug resolved, soon.
Comment 12 Mickael Istria CLA 2015-09-15 10:08:23 EDT
Putting a target milestone, hoping the submitted patch will be considered for next release.
Comment 13 Lars Vogel CLA 2016-04-20 12:03:39 EDT
Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.
Comment 14 Mickael Istria CLA 2017-05-24 10:58:06 EDT
Removing target but assigning it to myself to update proposed patch and self-review.
Comment 15 Mickael Istria CLA 2018-02-27 05:48:46 EST
This one will be for early 4.9.
Comment 16 Eclipse Genie CLA 2018-06-07 04:49:00 EDT
New Gerrit change created: https://git.eclipse.org/r/124166
Comment 17 Mickael Istria CLA 2018-11-19 16:28:25 EST
I'm removing the target here. I cannot commit to a target version for that patch as other things took priority over it.
Comment 19 Eclipse Genie CLA 2019-02-01 12:58:03 EST
New Gerrit change created: https://git.eclipse.org/r/136162
Comment 20 Alexander Kurtakov CLA 2019-02-01 13:38:28 EST
Mickael, would you please prepare a N&N entry?
Comment 21 Mickael Istria CLA 2019-02-01 13:59:10 EST
(In reply to Alexander Kurtakov from comment #20)
> Mickael, would you please prepare a N&N entry?

Sure, did you look at the content of the Gerrit change linked in comment #18 ? ;)
I'm also working on documentation.
Comment 23 Alexander Kurtakov CLA 2019-02-01 14:15:45 EST
Thanks Mickael.
Comment 24 Mickael Istria CLA 2019-02-01 14:19:22 EST
Reopening as it requires to update documentation as well.
Comment 25 Eclipse Genie CLA 2019-02-01 14:53:51 EST
New Gerrit change created: https://git.eclipse.org/r/136167
Comment 26 Eclipse Genie CLA 2019-02-02 04:22:06 EST
New Gerrit change created: https://git.eclipse.org/r/136174
Comment 29 Eclipse Genie CLA 2019-02-12 11:23:49 EST
New Gerrit change created: https://git.eclipse.org/r/136776
Comment 31 Noopur Gupta CLA 2019-02-21 04:16:26 EST
(In reply to Eclipse Genie from comment #22)
> Gerrit change https://git.eclipse.org/r/136162 was merged to [master].
> Commit:
> http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=7d41c98df5101e6627dd97bd240b32db6d4aa21a

The image should be no more than 520 pixels wide. I will update it now while editing the N&N.
Comment 32 Mickael Istria CLA 2019-02-21 04:21:15 EST
(In reply to Noopur Gupta from comment #31)
> The image should be no more than 520 pixels wide. I will update it now while
> editing the N&N.

Sorry for the trouble and thanks for the update!