Bug 22595 - No code assist in details pane
Summary: No code assist in details pane
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: Other Linux-GTK
: P1 normal (vote)
Target Milestone: 2.1   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-20 16:23 EDT by Jared Burns CLA
Modified: 2002-09-18 18:39 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Burns CLA 2002-08-20 16:23:54 EDT
Build 20020813 + latest plugins from 20020820

Code assist in the details pane of the variables view doesn't work.
Comment 1 Darin Wright CLA 2002-08-21 09:00:37 EDT
Works on Win2000. Is this a CTRL-space problem? Does code assist work from the 
pop-up menu? (Sometimes I find I must clear the details pane to get code assist 
to work, as previous entries can cause syntax errors which cause code assist to 
fail).
Comment 2 Jared Burns CLA 2002-08-22 15:43:02 EDT
It's a CTRL+SPACE problem. Code assist activates just fine if I activate it 
from the pop-up menu. Should we reassign this to SWT-GTK?
Comment 3 Darin Wright CLA 2002-08-22 16:01:09 EDT
It is either SWT or JFACE (content assist support). Kai, do you know if this is 
a known Linux issue?
Comment 4 Kai-Uwe Maetzel CLA 2002-09-04 03:39:02 EDT
There is no comparable problem reported. How do you activate content assist?
Comment 5 Jared Burns CLA 2002-09-04 11:00:17 EDT
1. Debug a program to a breakpoint.
2. Open the details pane of the variables view.
3. Put your cursor in the details pane, type "std", and hit CTRL+SPACE. 
Nothing happens.
4. With your cursor in the same location, right click and choose "Content 
Assist." The result of clicking this menu item is what *should* be happening 
when you hit CTRL+SPACE.
Comment 6 Darin Wright CLA 2002-09-11 12:24:21 EDT
I am now seeing the same problem on Win2000
Comment 7 Jared Burns CLA 2002-09-11 12:28:02 EDT
Is this another instance of Bug 22568?
Comment 8 Darin Wright CLA 2002-09-11 13:13:46 EDT
This appears to be due to some refactoring in the area of key bindings. The 
debug variables viewer is trying to bind the content assist action to the ctrl-
space key, using the global actions. The old code looks like:

// XXX: hook the "Java" content assist action - this is a hack to get content
// assist to work with the retargetable content assist action in the java UI
getViewSite().getActionBars().setGlobalActionHandler
("org.eclipse.jdt.ui.actions.ContentAssist", textAction); //$NON-NLS-1$
// Also hook CTRL-Space in case the java UI is not loaded/available
addVerifyKeyListener();

I tried the following, but that did not seem to work either:

// XXX: hook the "Java" content assist action - this is a hack to get content
// assist to work with the retargetable content assist action in the java UI
textAction.setActionDefinitionId
("org.eclipse.jdt.ui.edit.text.java.content.assist.context.information");
		getViewSite().getKeyBindingService().registerAction
(textAction); //$NON-NLS-1$
// Also hook CTRL-Space in case the java UI is not loaded/available
addVerifyKeyListener();

Kai, what is the proper way to do this? As well, note that since the debugger 
does not know about the Java UI, we use a string rather than a constant for the 
proper action ID. This makes us vulnerable to action id changes. Shouldn't the 
action ID be part of the text framework (since content assist is not java 
specific? or maybe it is). It appears the "Content Assist" action in the top 
level Edit menu is stealing the keypress, and not delegating to our action.

Comment 9 Darin Wright CLA 2002-09-13 12:14:37 EDT
For some reason, code assist works in the 20020911 drop, but not when self 
hosting.

*** This bug has been marked as a duplicate of 22568 ***
Comment 10 Darin Wright CLA 2002-09-13 12:14:59 EDT
Not a dup.
Comment 11 Darin Wright CLA 2002-09-16 10:37:51 EDT
This appears to be working with the latest plug-ins. Please verify.
Comment 12 Darin Wright CLA 2002-09-16 10:38:06 EDT
Please verify, Jared.
Comment 13 Jared Burns CLA 2002-09-17 12:18:18 EDT
Reopening. WORKSFORME stats defeats "verify bucket" queries.
Comment 14 Jared Burns CLA 2002-09-18 17:06:54 EDT
Verified.
Comment 15 Darin Wright CLA 2002-09-18 18:39:58 EDT
(Marking as verified)