Bug 225601 - Adopt API tooling for UI bundles
Summary: Adopt API tooling for UI bundles
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC2   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 224390 233285
Blocks:
  Show dependency tree
 
Reported: 2008-04-03 12:54 EDT by Boris Bokowski CLA
Modified: 2008-05-30 22:04 EDT (History)
3 users (show)

See Also:
Mike_Wilson: pmc_approved+
eclipse: review+

Attachments
patch for org.eclipse.ui.ide, and ignoring false positives for org.eclipse.jface.databinding (60.94 KB, patch)
2008-05-02 14:43 EDT, Boris Bokowski CLA 		no flags Details | Diff
patch for org.eclipse.jface and org.eclipse.jface.databinding (51.45 KB, patch)
2008-05-13 16:31 EDT, Boris Bokowski CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Bokowski CLA 2008-04-03 12:54:43 EDT
Comment 1 Boris Bokowski CLA 2008-04-03 13:03:04 EDT 
done:
org.eclipse.core.databinding
org.eclipse.core.databinding.beans
org.eclipse.jface.databinding
Comment 2 Boris Bokowski CLA 2008-04-04 14:38:16 EDT 
done:
org.eclipse.core.commands
org.eclipse.ui
Comment 3 Boris Bokowski CLA 2008-04-04 15:08:03 EDT 
done everything else except:
org.eclipse.ui.ide (waiting for the next I build)
org.eclipse.jface (waiting for the next I build)
org.eclipse.ui.views.properties.tabbed (waiting for bug 224390)
org.eclipse.ui.carbon (Kim?)
Comment 4 Boris Bokowski CLA 2008-04-04 15:20:54 EDT 
We still need to go through and change our English sentences "should not be implemented" etc. into the machine-readable forms (@noimplement/@noextend)
Comment 5 Paul Webster CLA 2008-04-04 15:56:54 EDT 
Released 2 fixes for AbstractPresentationFactory and ISharedImages

Also opened bug 225826

PW
Comment 6 Kim Horne CLA 2008-04-14 10:21:52 EDT 
I've added the API nature to the carbon fragment along with a @noreference tag to the single class in this component.  Additional javadoc and an updated classpath were also added to remove the last of the compiler warnings.
Comment 7 Boris Bokowski CLA 2008-05-02 14:41:33 EDT 
Moving to RC1 because bugs in the API tooling prevented me from converting all our projects in M7.
Comment 8 Boris Bokowski CLA 2008-05-02 14:43:58 EDT 
Created attachment 98482 [details]
patch for org.eclipse.ui.ide, and ignoring false positives for org.eclipse.jface.databinding
Comment 9 Kim Horne CLA 2008-05-02 14:49:53 EDT 
Theoretical +1.
Comment 10 Boris Bokowski CLA 2008-05-02 15:37:24 EDT 
Patch released to HEAD.
Comment 11 Boris Bokowski CLA 2008-05-13 16:31:43 EDT 
Created attachment 100045 [details]
patch for org.eclipse.jface and org.eclipse.jface.databinding
Comment 12 Boris Bokowski CLA 2008-05-13 16:33:22 EDT 
Kim, another patch - org.eclipse.jface was not API Tooling enabled yet due to bugs in the tooling, and similarly for data binding, the problem filters needed updating in response to a bugfix in PDE API tooling. +1?
Comment 13 Kim Horne CLA 2008-05-13 16:49:00 EDT 
+1.
Comment 14 Boris Bokowski CLA 2008-05-13 16:57:12 EDT 
Released to HEAD.
Comment 15 Philipe Mulet CLA 2008-05-23 04:30:05 EDT 
Please adjust the target milestone, so it does not point at a closed milestone in the past.
Comment 16 Boris Bokowski CLA 2008-05-26 13:58:44 EDT 
Marking as fixed now that the only outstanding issue (bug 233285) has been fixed.
Comment 17 Boris Bokowski CLA 2008-05-30 22:04:17 EDT 
Verified that all our plug-ins have the API tooling enabled.