Community
Participate
Working Groups
Build ID: N20080401-2000 Steps To Reproduce: Improve UI of the Secure Storage view and make sure the icons used in the menu bar, context menu, and wizards are Eclipse conform. Knowing issues which have to be addressed (see bug 221375): 1. Delete - Plan is to have two icons in the same toolbar "Delete Node" and "Delete Value" 2. Show Value - The value rectangle by itself. The glasses are a metaphor for 'Read', as in Read/Write. 3. Encrypt Value - Large lock. 4. Decrypt Value - Large key, or a key inserted in lock. 5. Wizard banners - look a bit cramped/blurry and could possibly take up more space or use larger images More information:
Created attachment 94631 [details] proposal to discuss (context menu contains all menu items) Why not use table tree instead of tree plus table? Having only one widget we can replace the commands "Delete Node" and "Delete Value" with the single command "Delete". "Show Value" is similar to "Open" in the Navigator view. So I would prefer to short it to "Show" and display it without an icon as first menu item in the context menu. It would be nice if double clicking a value (or pressing Enter) will show it. The context menu should only contain menu items which can be generally applied on selection. I.e. if no values are selected do not display "Show Value" in context menu. Other icons see attachment; proposal for wizard banners coming soon...
Kelvin, Kevin, please keep in mind that 3.4M7 date is week of April 28th so if there are changes to be done for 3.4 they have to be ready by April 25th. Holger, as to the change from (tree + table) to (TableTree), at this point I'd like to avoid doing it unless it significantly helps with something.
Ping: one I-build remains till 3.4M7. Is this intended for 3.4 or later?
Graphic request put in with design team to work with Holger to close off on this work.
Created attachment 96752 [details] proposal to review (ZIP file containing all icons)
Created attachment 96753 [details] proposal to review (preview: context menu contains all menu items) Kelvin, please review!
Due to the changes in the bug 227310 and bug 227428 for Eclipse 3.4 the context menus, and as a result, icons are only going to be visible if debug options are set for the security UI bundle. I would like to come back to the secure storage view after 3.4 and see if we can find a solution to the "passer by clicks a button on my unattended computer" situation. It is not trivial as we generally don't have a "master" password known to the user. In a meantime, we'll have more time to work out icons :-).
Kelvin was unable to work further with you because his wife delivered their first baby, a healthy boy, ahead of due date, and he needed to focus on wrapping up other project work. So it's good there's more time to work out icons. I'm available to cover for Kelvin while he's away on paternity leave over the next month, should further work be needed before his return.
(In reply to comment #7 and #8) Best wishes to Kelvin, his wife, and his son! I checked build N20080421-2000 and found in preferences Security > Security Storage > Contents the button "Export..." which brings up a dialog with one of the new wizard icon. From my point of view the icons are ready to pass final review. We should carry one with the icons still in use. If all icons not longer required this bug should be closed. Unfortunately, I do not find out to enable context menu (in Run I enabled Tracing: org.eclipse.equinox.security - debug and debug/loginFramework). But I think, it is overkill to add icons to a by default hidden context menu.
Best wishes to Kelvin and family! As for the icons - yes, that is the best debug view ever :-). I am sorry that we won't see those menus by default but people have spoken. I do hope to re-introduce the view in future, once everybody get used to the secure storage, probably in a more user-oriented form, but that certainly is not for 3.4. (To see the menus, the debug options on org.eclipse.security.ui - that's UI bundle - needs to be enabled (both options, debug and storage). The show value, decrypt and encrypt options are effectivelly commented out.)
(In reply to comment #10) What's about the export wizban icon? Will it be used in 3.4?
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
I think any future improvements should start with a new bug.
