Community
Participate
Working Groups
The secure storage view could use some icons. The most interesting would be the icon associated with the "Secure storage" view itself. It could be something like a bank vault door. The are several commands that could use icons if they are available: -> Tree of nodes: context menu: Add node - probably a large "+" sign? Remove node - probably a large "-" sign? Refresh - could be a circle with arrows -> Table of values: context menu: Add value - could be a small "+" sign Remove value - could be a small "-" sign Show value - could be an eye Encrypt value - probably a lock image? Decrypt value - probably a lock image crossed?
Kelvin, can you please have a look at this graphic request for the Equinox team?
Created attachment 92664 [details] proposal to discuss (but created without understanding the functionality) What do a node and a value represent? Is there already a prototype or some screenshots available? Can _add_ node/value replaced by _new_ node/value? Should "Show value" negate to "Hide value"?
Perfect, thank you for quick reply! I especially like the icon for the secure storage view with multiple locks. As to what the secure storage does, to give a [simplified] real-life example, let’s say you can use the secure storage to save passwords to connect to different services. You’ll have a node called “Internet” with bunch of password values under it; and a node called “CVS” with password for CVS connections. (If you use I-builds, the last week SDK I-build has the view under “General” category: Window -> Show View -> Other… -> General | Secure storage.) Most icons look very good; one thing is that both “removal” icons probably would fit better if they correspond to the “add” icons. The “new node” icon has folder with plus sign; the “remove node” icon could be the same folder with the “x” mark – the red “x” you used would work well, if it is scaled a bit a positioned like the “+” sign in the “add” icon. Similarly, for the “new value” – just like you did for addition, it would be cool to have that “table” icon with the red “x” on it. I don’t know if it makes sense as icons are so small – but do you think it is possible to have the base icon for the “add/remove value” to look like a table. (Probably, adding a “header” and “column” to the white rectangle?) The “encypt”/ “decrypt” icons: To easier differentiate between them could we have just a lock itself for “encrypt” and a “broken” lock (maybe, a lock with a wavy line going though it?) for “decrypt”? Or just a lock with that red “x” :-). It is important to differentiate between those two commands and the icons look too similar to each other. The “hide value” is actually a “show value”; there is no "hide value". It offers to the user to [temporarily] see the encrypted value. (Normally the encrypted value is just a bunch of dots on the screen.) As such I though it could be an image of an eye if some sort. Or anything really :-).
Created attachment 92701 [details] Secure storage view - menu 1
Created attachment 92702 [details] Secure storage view - menu 2
Created attachment 92703 [details] Possible ideas for "Show value" icon
Created attachment 92849 [details] Proposal: Secure Storage icon set I tested SDK I-build: I think there is fine line between "Add" and "New". Only already existing things can be added and new things have to be created. For my understanding in secure storage new nodes and values are created, right? The reverse of "new" is "delete". So we can use the Eclipse standard delete icon. (By the way, view names and menu items should be in upper-case: "Secure storage" => "Secure Storage", "Show value" => " Show Value", etc. and column titles should be singular: "Values" => "Value"; In a value of a value you could store a password or key. And the stored key has an unique key. A little bit confusing. Maybe a value should be identified by a name or ID instead by a key.)
Created attachment 92850 [details] Preview: Proposal - Secure Storage icon set
Created attachment 92961 [details] Proposal: Secure Storage icon set (polished)
Created attachment 92962 [details] Preview: Proposal - Secure Storage icon set (polished)
Created attachment 92964 [details] Picture of the login dialog This is absolutely great, thank you! And you even added icons for dialogs - woot, thank you! You make a very good point on names to use, I'll change them. One thing I'd like to change are "delete" icons. Both "detele node" and "delete value" actions will be added to the same toolbar. As such, it would be highly desirable to have different icons for them. Would it be possible to style the "delete" icons similary to "New" icons with red "x" instead of "+"? Speaking about dialogs, If you have a minute, could you look at the attached login dialog? I guess a variation of the image with multiple locks (same as the secure storage view) could be used there - probably with some overlaping element indicating that this action is "dynamic", action in progress? Perhaps, an arrow striking the locks?
Created attachment 92969 [details] Secure Storage icon set - added: delete_node.gif, delete_value.gif, and login_wiz.png Login dialog: Do you need a 16x16 pixel icon?
Holger, thank you! It is hard to even compare "before" and "after" look of those dialogs – it looks so much better now. From a grown-in-a-basement look it turned into something professional. Again, huge thank you – outstanding work! New icons are added and should appear in 3.4M6, along with changes to the menu labels.
The icons look pretty good and well-rendered, although I have some comments/feedback on the metaphors. In general, the icons show the 'action + object' to represent the various commands. I would prefer to only show the action if possible since it is understood what the object is based on the context menu. For example, 'Delete' is more clearer as a large red x instead of the adding the value metaphor and deemphasizing the command. Also, there is less icon repetition by removing the 'object' from each command. For the node context menu, I like the iteration that was showed in the latest preview.png. The 'value' rectangle can possibly be removed from 'New' to simplify it a bit. For the value context menu, New value - Why is the lock here, could it be just the value rectangle + new sparkle? Delete - Prefer the Red X Show value - The value rectangle by itself. The glasses are a metaphor for 'Read', as in Read/Write. Encrypt value - Large lock. Decrypt value - Large key, or a key inserted in lock. As for the wizard banners, the composition looks a bit too tight, and some of the metaphors are quite small. Also, the 'new' sparkle is not usually included in the wizban.
Kevin, it is very useful to read your comments, but some points have been already discuseed. For the new / delete icons, they will be present on the same toolbar and therefore user must be able to differentiate between, say, "delete node" and "delete value" icons. New value - to me, lock makes sense as we are speaking about adding an encrypted value. As for the rest of it - it looks purely artistic; it would be nice to see your images.
Btw they were "Kelvin's" comments not mine (Kevin). For context, Kelvin does much of the artwork for the platform. Holger, what are your thoughts? Its really great seeing artwork contributions from the community.
Should we perhaps open a new bug to cover feedback on the new artwork? This bug is closed and it doesn't seem right to reopen it for the discussion.
Created attachment 93688 [details] updated "new value" wizban icon (In reply to comment #14) > Show value - The value rectangle by itself. The glasses are a metaphor for > 'Read', as in Read/Write. > ... but also used in Debug's "Watchpoint" icon. Some idea what to use instead? > Encrypt value - Large lock. > Decrypt value - Large key, or a key inserted in lock. > Well, I have not managed to put something in this 16x16 Pixel which could be recognised as a key. > As for the wizard banners, the composition looks a bit too tight, and some of > the metaphors are quite small. > What do you mean with "too tight" and "small metaphors"? > Also, the 'new' sparkle is not usually included in the wizban. > Good catch! (see attachment)
Sorry for the delay, we've been trying to tie a few loose ends in time for M6. I think the discussion at this point shifts into UI standards and customs that I am not aware of. From my perspective, it will be fine with either opening a new bug/enhancement or continue in this one - up to you. Just be sure to let me know what the result is so that I can update contents of the security.ui bundle. (I'd like you to keep in mind that all action icons will be present on the same toolbar. As a result, user should be able to differentiate between them.)
Apologies for my delay as well. Sure, we can open a new bug for this. Sorry I missed that comment regarding the differentiation for the toolbar icons. Is it possible to use different icons for the toolbar (action+object) and the context menu (action only)?
(In reply to comment #18) > ... but also used in Debug's "Watchpoint" icon. Some idea what to use instead? We don't really have a metaphor for 'Show'...the icon is usually just the object that is to be shown. > What do you mean with "too tight" and "small metaphors"? The wizard icons look a bit cramped/blurry and could possibly take up more space or use larger images.
Holger, I'm really pleased to see graphics contributions from the community. Thanks again! This is really great. We usually do a refinement pass of our own work and I'd like to see us put the same effort into this work. We can approach this two ways: 1) You and Kelvin can continue to discuss it, then YOU can submit updated artwork in time for 3.4. I like this approach because it facilitates a discussion on how we approach graphics design on the platform, spreading the knowledge to the community. 2) If you're too busy for that, Kelvin can work from your artwork and make the tweaks. I'm fine with either. I recognize that, especially when it comes to artwork, people can feel very attached to their work, so I'd like to proceed in whichever way is more amenable to you. Kelvin, I suggest we manage the bug tracking as follows: 1. Please open a new bug to track the refinement pass. 2. Condense your comments based on the discussion so far to form the description. 3. Mark the new bug as dependent on this one so we have the traceability between them, and add existing folks to CC.
(In reply to comment #20) > Is it possible to use different icons for the toolbar (action+object) > and the context menu (action only)? Yes, if that really helps I can create separate commands.
bug 225435 opened for further improvements...
