Bug 225334 - [Patch] Layout on the "Apply Patch" wizard gets messy
Summary: [Patch] Layout on the "Apply Patch" wizard gets messy
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P4 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords: polish
: 239126 272973 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-04-02 10:06 EDT by Tomasz Zarna CLA
Modified: 2009-04-23 11:22 EDT (History)
3 users (show)

See Also:

Attachments
Screen shot (43.97 KB, image/png)
2008-04-02 10:07 EDT, Tomasz Zarna CLA 		no flags Details
Patch v01 (3.23 KB, patch)
2009-04-16 04:58 EDT, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (31.18 KB, application/octet-stream)
2009-04-16 04:58 EDT, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2008-04-02 10:06:30 EDT 
I20080330-1350

Steps to reproduce:
1. Open the "Apply Patch" wizard for the second patch for bug 214796, attachment 93623 [details].
2. Double-click on the ProxyType.java class to reveal it's content
3. Fold "Patch Options" by clicking on it
=> Patch Content and Java Structure Compare panes gets enormously expanded, compare panes are lost (need to scroll down to see them). Expanding the "Patch Options" doesn't help.
Comment 1 Tomasz Zarna CLA 2008-04-02 10:07:59 EDT 
Created attachment 94542 [details]
Screen shot

It doesn't look good, does it?
Comment 2 Tomasz Zarna CLA 2008-04-02 10:19:28 EDT 
PS. 'Import Declarations' and 'ProxyType' nodes from the structure pane should be expanded.
Comment 3 Tomasz Zarna CLA 2008-04-25 08:45:51 EDT 
It seems that nobody else has noticed it. Not critical, I'm deferring it to 3.5.
Comment 4 Tomasz Zarna CLA 2008-07-02 11:15:09 EDT 
*** Bug 239126 has been marked as a duplicate of this bug. ***
Comment 5 Tomasz Zarna CLA 2008-07-02 11:19:15 EDT 
Bug 239126 also brings attention to flickering and unnecessary scrollbars. Additional screen shot from that bug: https://bugs.eclipse.org/bugs/attachment.cgi?id=106237.
Comment 6 Tomasz Zarna CLA 2009-04-15 08:07:10 EDT 
The first I would do would be replacing ScrolledForm with Form in the wizard.
Comment 7 Tomasz Zarna CLA 2009-04-16 04:58:24 EDT 
Created attachment 132050 [details]
Patch v01

Patch that replaces ScrolledForm with Form. This removes the unnecessary scrollbars. 

I haven't noticed the flickering so if anybody sees it, feel free to open a new bug for it.
Comment 8 Tomasz Zarna CLA 2009-04-16 04:58:32 EDT 
Created attachment 132051 [details]
mylyn/context/zip
Comment 9 Tomasz Zarna CLA 2009-04-16 05:24:17 EDT 
Opened bug 272464 for an issue with TextViewers scrollbars observed while fixing this one.
Comment 10 Tomasz Zarna CLA 2009-04-16 09:54:44 EDT 
Released to HEAD, available in builds >N20090415-2000.
Comment 11 Tomasz Zarna CLA 2009-04-23 11:22:25 EDT 
*** Bug 272973 has been marked as a duplicate of this bug. ***