Bug 224921 - [IDE] BIDI3.4:HCG_Incorrect display of history in File menu in mirrored mode
Summary: [IDE] BIDI3.4:HCG_Incorrect display of history in File menu in mirrored mode
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows All
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 229010
Blocks:
  Show dependency tree
 
Reported: 2008-03-31 11:28 EDT by Tomer Mahlin CLA
Modified: 2008-05-15 09:09 EDT (History)
3 users (show)

See Also:
emoffatt: review+


Attachments
Correct display in non mirrored (aka LTR) mode (35.92 KB, image/jpeg)
2008-03-31 11:30 EDT, Tomer Mahlin CLA
no flags Details
Incorrect display in mirrored (aka RTL) mode (35.84 KB, image/jpeg)
2008-03-31 11:32 EDT, Tomer Mahlin CLA
no flags Details
Option 1: acceptable display of menu items in mirrored mode (35.13 KB, image/jpeg)
2008-03-31 11:33 EDT, Tomer Mahlin CLA
no flags Details
Option 2: acceptable display of menu items in mirrored mode (34.96 KB, image/jpeg)
2008-03-31 11:34 EDT, Tomer Mahlin CLA
no flags Details
Option 3: acceptable display of menu items in mirrored mode (35.51 KB, image/jpeg)
2008-03-31 11:35 EDT, Tomer Mahlin CLA
no flags Details
File menu with MRU items in English version of Paint program (18.79 KB, image/jpeg)
2008-04-17 05:10 EDT, Tomer Mahlin CLA
no flags Details
File menu with MRU items in Hebrew version of Paint program (20.28 KB, image/jpeg)
2008-04-17 05:11 EDT, Tomer Mahlin CLA
no flags Details
File menu with MRU items in English version of WordPad program (24.51 KB, image/jpeg)
2008-04-17 05:12 EDT, Tomer Mahlin CLA
no flags Details
File menu with MRU items in Hebrew version of WordPad program (16.25 KB, image/jpeg)
2008-04-17 05:13 EDT, Tomer Mahlin CLA
no flags Details
File menu with MRU items in English version of MS Word program (16.21 KB, image/jpeg)
2008-04-17 05:14 EDT, Tomer Mahlin CLA
no flags Details
File menu with MRU items in Hebrew version of MS Word program (15.04 KB, image/jpeg)
2008-04-17 05:15 EDT, Tomer Mahlin CLA
no flags Details
MRU menu v01 (6.40 KB, patch)
2008-05-08 10:51 EDT, Paul Webster CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomer Mahlin CLA 2008-03-31 11:28:33 EDT
Build ID: IES 3.4

Steps To Reproduce:
1. Run Eclipse with -nl iw -dir rtl command line options
2. Open several files 
3. Observe how recently opened files appear in File submenu

In non mirrored mode (LTR mode) the display is:
# <file name> [<file path>]
and it is aligned to the left

In mirrored mode (RTL mode) the display is the same as in non-mirrored mode:
# <file name> [<file path>] 
and it is aligned to the RIGHT. This is not acceptable.

Expected result:
-----------------
Any one of the following options is acceptable:

Option 1:
[<file path>] <file name>  #
alignment = right

Option 2:
<file name> [<file path>] #
alignment = right

Option 3: 
# <file name> [<file path>]
alignment = left
Comment 1 Tomer Mahlin CLA 2008-03-31 11:30:35 EDT
Created attachment 94235 [details]
Correct display in non mirrored (aka LTR) mode

This is how recently used files correctly appear in File menu in non mirrored mode.
Comment 2 Tomer Mahlin CLA 2008-03-31 11:32:13 EDT
Created attachment 94236 [details]
Incorrect display in mirrored (aka RTL) mode

This is how currently recently used files are incorrectly displayed in File menu in mirrored (aka RTL) mode.
Comment 3 Tomer Mahlin CLA 2008-03-31 11:33:47 EDT
Created attachment 94237 [details]
Option 1: acceptable display of menu items in mirrored mode 

This is one of 3 acceptable options for correct display of recently used files in File menu in mirrored (RTL) mode.
Comment 4 Tomer Mahlin CLA 2008-03-31 11:34:37 EDT
Created attachment 94238 [details]
Option 2: acceptable display of menu items in mirrored mode 

This is second of 3 acceptable options for correct display of recently used files in File menu in mirrored (RTL) mode.
Comment 5 Tomer Mahlin CLA 2008-03-31 11:35:16 EDT
Created attachment 94239 [details]
Option 3: acceptable display of menu items in mirrored mode 

This is third of 3 acceptable options for correct display of recently used files in File menu in mirrored (RTL) mode.
Comment 6 Eric Moffatt CLA 2008-04-16 15:23:47 EDT
Tomer, what do real Windows apps (Word, PowerPoint...) show in their MRU list? It's not the same format but it might help to pick one or the other of the options...
Comment 7 Tomer Mahlin CLA 2008-04-17 05:07:52 EDT
 In standard Windows programs the number appear on the right side of the file name. This means that in order to show MRU items similarly to how Windows shows them we should use either one of the following options:

Option 1:
  [<file path>] <file name> #
  alignment = right

Option 2:
  <file name> [<file path>] #
  alignment = right

 I will attach screenshots illustrating how Paint, WordPad and MS Word show MRU items in appropriate File menu.
Comment 8 Tomer Mahlin CLA 2008-04-17 05:10:35 EDT
Created attachment 96399 [details]
File menu with MRU items in English version of Paint program

The attached file illustrates how file menu including MRU items looks in English version of Paint program
Comment 9 Tomer Mahlin CLA 2008-04-17 05:11:25 EDT
Created attachment 96400 [details]
File menu with MRU items in Hebrew version of Paint program

The attached file illustrates how file menu including MRU items looks in Hebrew version of Paint program
Comment 10 Tomer Mahlin CLA 2008-04-17 05:12:21 EDT
Created attachment 96401 [details]
File menu with MRU items in English version of WordPad program

The attached file illustrates how file menu including MRU items looks in English version of WordPad program
Comment 11 Tomer Mahlin CLA 2008-04-17 05:13:12 EDT
Created attachment 96402 [details]
File menu with MRU items in Hebrew version of WordPad program

The attached file illustrates how file menu including MRU items looks in Hebrew version of WordPad program
Comment 12 Tomer Mahlin CLA 2008-04-17 05:14:21 EDT
Created attachment 96403 [details]
File menu with MRU items in English version of MS Word program

The attached file illustrates how file menu including MRU items looks in English version of MS Word program
Comment 13 Tomer Mahlin CLA 2008-04-17 05:15:04 EDT
Created attachment 96404 [details]
File menu with MRU items in Hebrew version of MS Word program

The attached file illustrates how file menu including MRU items looks in Hebrew version of MS Word program
Comment 14 Tomer Mahlin CLA 2008-04-17 05:20:50 EDT
 I minor mistake in the illustrations' titles. Illustrations for MS Word application actually belong to WordPad program and vice versa (illustrations for WordPad application actually belong to MS Word program).
Comment 15 Paul Webster CLA 2008-05-08 10:51:36 EDT
Created attachment 99302 [details]
MRU menu v01

This should supply the file history menu using

Option 2:
  <file name> [<file path>] #
  alignment = right



in RTL mode.

PW
Comment 16 Paul Webster CLA 2008-05-08 10:52:18 EDT
Eric, could I get you to have a quick look?

PW
Comment 17 Eric Moffatt CLA 2008-05-08 14:41:28 EDT
Looks good to me....
Comment 18 Paul Webster CLA 2008-05-08 15:25:23 EDT
Released for I20080508-2000
PW
Comment 19 Tomer Mahlin CLA 2008-05-15 09:09:23 EDT
Works fine in I20080513 build.