Bug 224723 - [Themes] Default text font too small in high contrast
Summary: [Themes] Default text font too small in high contrast
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Kevin McGuire CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on: 205474
Blocks:
  Show dependency tree
 
Reported: 2008-03-28 15:52 EDT by Kevin McGuire CLA
Modified: 2008-04-24 13:33 EDT (History)
1 user (show)

See Also:

Attachments
snapshot of 3.3.2 vs. current (77.00 KB, image/jpeg)
2008-03-28 15:55 EDT, Kevin McGuire CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2008-03-28 15:52:18 EDT 
The default text font when working in high contrast is too small.  This is a change from 3.3.2.  I say "too small" because (1) I think it'd now be hard to read and (2) is a lot smaller than the package explorer list font (which gets bigger in high contrast).

I've marked major since I think this might now be quite difficult for someone with vision problems to use and the change seems unintended.
Comment 1 Kevin McGuire CLA 2008-03-28 15:55:43 EDT 
Created attachment 94055 [details]
snapshot of 3.3.2 vs. current

(build i20080327-0100)

Snapshot shows comparison of text font from 3.3.2 (foreground) and i0327 (background).  Note size difference between new text font and list font which has remained unchanged between releases.
Comment 2 Kevin McGuire CLA 2008-03-28 15:56:42 EDT 
Note although screen shot shows JDT text I've confirmed a plain text file uses same (small) font.
Comment 3 Dani Megert CLA 2008-03-28 16:29:09 EDT 
Man this *is* too small. Need to investigate.
Comment 4 Dani Megert CLA 2008-03-31 05:21:38 EDT 
The bug is in JFace: we use the JFace text font ("org.eclipse.jface.textfont" / JFaceResources.getTextFont()). So far this font correctly picked up the font when starting in high contrast mode. This is no longer the case.
Comment 5 Dani Megert CLA 2008-03-31 08:11:16 EDT 
FYI: This got broken during 3.4 M3 by "fixing" bug 205474.
Comment 6 Kim Horne CLA 2008-03-31 08:49:06 EDT 
(In reply to comment #5)
> FYI: This got broken during 3.4 M3 by "fixing" bug 205474.
> 

"Thanks" Dani.  Reopening.
Comment 7 Kevin McGuire CLA 2008-03-31 11:25:15 EDT 
I'll look into this one
Comment 8 Kevin McGuire CLA 2008-04-22 09:56:23 EDT 
Marking as dependent on bug #205474.  Expect that fixing #205474 will fix this.
Comment 9 Kevin McGuire CLA 2008-04-24 13:33:32 EDT 
Verified that fix in bug #205474 gives correct size text font in HC