Bug 22465 - Wrong ant script causes fatal error written to console
Summary: Wrong ant script causes fatal error written to console
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 2.1 M2   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords: core
Depends on:
Blocks:
 
Reported: 2002-08-15 06:01 EDT by Dani Megert CLA
Modified: 2002-10-07 13:20 EDT (History)
0 users

See Also:

Attachments
bad ant script (850 bytes, text/plain)
2002-10-04 12:49 EDT, Dani Megert CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2002-08-15 06:01:08 EDT 
Build 20020813

I missed to set an attribute in my ant file and got warned with a dialog (ok).
In addition the following entry was written to the DOS console:

[Fatal Error] :14:15: Element type "isset" must be followed by either attribute
specifications, ">" or "/>".

I guess this is the ant output (and for ant it might be a fatal error) however
it is misleading for an Eclipse user to see a fatal error in the Eclipse console. 

It would be nice if it would be at least prefixed with ant:
ant: [Fatal Error] :14:15: Element type "isset" must be follow....
Comment 1 Darin Swanson CLA 2002-09-30 15:15:36 EDT 
On the latest (released to the Oct 1 integration build), I cannot reproduce the 
problem.
Comment 2 Darin Swanson CLA 2002-09-30 15:16:09 EDT 
Please verify (Jared)
Comment 3 Jared Burns CLA 2002-10-04 12:35:22 EDT 
Daniel, can you provide a script (the smaller, the better) which demonstrates 
the problem you had? Can you still reproduce this problem on the latest build?
Comment 4 Dani Megert CLA 2002-10-04 12:48:28 EDT 
Attached a file causing the problem.
Comment 5 Dani Megert CLA 2002-10-04 12:49:17 EDT 
Created attachment 2106 [details]
bad ant script
Comment 6 Dani Megert CLA 2002-10-04 12:51:28 EDT 
The attached script works. Now introduce an error - e.g. remove the '>' of the
closing target tag. This makes line 5 look like ==>
	</target
Comment 7 Jared Burns CLA 2002-10-07 10:42:23 EDT 
Thanks. I also cannot reproduce the problem on the new code.
Comment 8 Jared Burns CLA 2002-10-07 10:43:20 EDT 
Verified.
Comment 9 Dani Megert CLA 2002-10-07 11:09:50 EDT 
What do you mean with "new code"? Testing against 20021001 still shows me the
error. If you did not test with newer code (which changed in that area) then you
should see the error. Here are the steps again:

1. add attached file to workspace
2. remove the '>' of the closing target tag. This makes line 5 look like ==>
	</target

3. run ant on the file
==> Error appears in *console* where where I started Eclipse (not in the .log):
[Fatal Error] :7:2: The end-tag for element type "target" must end with a '>'
delimiter.
Comment 10 Jared Burns CLA 2002-10-07 11:20:49 EDT 
New work in the external tools UI for the past month or so has taken place in 
a side branch. It should be noted that I've just started working on the UI and 
had nothing to do with this. ;)

We just moved the code from this branch into the HEAD branch on Friday and we 
don't know when we'll start submitting it to builds (we inherited a mess). To 
test on the new code, you'd need to check the org.eclipse.ui.externaltools 
project out of the HEAD branch.
Comment 11 Dani Megert CLA 2002-10-07 13:20:06 EDT 
Ok. I just wanted to make sure that the console has been checked for the error
to appear and not the .log.