Bug 224626 - 'Apply Patch wizard > Show matched hunks' loses context -> remove?
Summary: 'Apply Patch wizard > Show matched hunks' loses context -> remove?
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 220934 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-28 10:22 EDT by Markus Keller CLA
Modified: 2019-09-06 16:19 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-03-28 10:22:15 EDT 
I20080327-2251

In the Apply Patch wizard, toggling the checkbox 'Show matched hunks' loses the context (expansion state, selection, scroll state) of the 'Patch Contents' tree.

Is the toggle even necessary? I would just show the matched hunks all the time. The additional '+' on files does not hurt if you don't care about the hunks. 

Without the checkbox, the only thing you lose is the possibility to filter out matched hunks when there are also unmatched hunks in the file. I don't think that's useful anyway, especially if the price for this is another checkbox.

Omitting the checkbox also avoids discussions on whether the checkbox should be enabled by default and when its state should be persisted.
Comment 1 Tomasz Zarna CLA 2009-03-06 11:51:59 EST 
*** Bug 220934 has been marked as a duplicate of this bug. ***
Comment 2 Eclipse Webmaster CLA 2019-09-06 16:19:30 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.