Bug 224324 - [QVTc] Save changes broken
Summary: [QVTc] Save changes broken
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: UMLX (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ed Willink CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-27 06:05 EDT by Victor Roldan Betancort CLA
Modified: 2012-12-11 15:33 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Roldan Betancort CLA 2008-03-27 06:05:05 EDT
Build ID: I20071213-1700

Bug existing in the QVTc editor. Haven't tried out for QVTr.

Start within a non-dirt editor.

1. Type a carry return in any part of the code, even in the middle of a reserved word (which will end up generating an error when saving)
2. Save, either using Control-S or the save button on the toolbar. Text might appear marked as error or not, which is irrelevant to reproduce the bug.
3. Type any key except backspace nor delete key. The editor wont appear as dirty until you click any of these two buttons.
Comment 1 Victor Roldan Betancort CLA 2008-03-28 11:50:55 EDT
You could also reproduce the bug by first generating a sintactic error, saving and then typing anything: editor won't ever get dirty, unless you press backspace or delete.
Comment 2 Ed Willink CLA 2008-03-28 15:34:44 EDT
Problem 1: TextEditor aggregates character sequences as an extensible 'Typing' operation. TextEditor fails to observe intervening Save in mid sequence, and so can extend pre-save operation post-save; so until the cursor is repositioned after a save there is no new operation to signal that further typing is dirty. Fixed in CVS. (org.eclipse.gmt.umlx.editor plug-in).

Problem 2. Control-S does not work after some typing, but File Save does. Probably an action binding issue.
Comment 3 Ed Willink CLA 2008-04-01 03:40:23 EDT
Control-S was using TextEditor's SAVE action, whose enabling was experiencing a race condition with respect to the multi-page dirty flag and which failed to clear multi-editor dirty after a single editor save.

File->Save uses MultiPageEditorPart's SAVE action, which works much better.

Installation of the TextEditor SAVE action is therefore suppressed in LazyTextPageEditor so that the MultiPageEditorPart SAVE is always in use.

Control-S is fixed in CVS. (org.eclipse.gmt.umlx.editor plug-in).

?? How many more TextEditor actions are broken ?? Leaving OPEN till other actions resolved.