Comment 1 pizhou 2010-03-26 00:57:14 EDT

Is there any technical difficulty to implement this enhancement? I think this enhancement is valid and I like it.

Comment 2 Dani Megert 2010-03-26 02:16:38 EDT

So far we only use FilteredTree for single column trees.

Comment 3 pizhou 2010-03-26 02:36:13 EDT

What about error log view? It has several columns but it uses filter tree.

Comment 4 Dani Megert 2010-03-26 03:51:33 EDT

Right you can turn the Log into a tree by grouping, but it looks and works strange i.e. it's not intuitive to which column(s) the filter string applies.

Currently we don't have time to look into this.

Comment 5 pizhou 2010-03-26 04:36:37 EDT

(In reply to comment #4)
> Right you can turn the Log into a tree by grouping, but it looks and works
> strange i.e. it's not intuitive to which column(s) the filter string applies.
> 
> Currently we don't have time to look into this.

(In reply to comment #4)
> Right you can turn the Log into a tree by grouping, but it looks and works
> strange i.e. it's not intuitive to which column(s) the filter string applies.
> 
> Currently we don't have time to look into this.

The implementation of the error log view is: if any field(Message/Plugin/Date) of a log entry matches the filter, the log entry will show up.

Since you are very busy, I'd like to provide a patch for this enhancement. What do you think of it?

Comment 6 Dani Megert 2010-03-26 04:43:41 EDT

As said, I'm not yet convinced. The Error Log filtering doesn't work very well. When I e.g. type "Sess" then the view is cleared (but that's another story). It is confusing for the user that he doesn't know what's actually being part of the filtering. Lets assume we have

AAA FOO
FOO BAR
CCC FOO
DDD FOO

And I'd like to find the template Foo. This wouldn't work because the "smart" filtering thinks I also want the others that have FOO in the second column and hence I get too many matches.

Comment 7 pizhou 2010-03-26 04:45:24 EDT

(In reply to comment #6)
> As said, I'm not yet convinced. The Error Log filtering doesn't work very well.
> When I e.g. type "Sess" then the view is cleared (but that's another story). It
> is confusing for the user that he doesn't know what's actually being part of
> the filtering. Lets assume we have
> 
> AAA FOO
> FOO BAR
> CCC FOO
> DDD FOO
> 
> And I'd like to find the template Foo. This wouldn't work because the "smart"
> filtering thinks I also want the others that have FOO in the second column and
> hence I get too many matches.

So you think just filter the name is enough. I also think so. I think this behavior is not confusing.

Comment 8 Dani Megert 2010-03-26 09:14:18 EDT

After thinking about this a bit more, it's not a good idea to individually start to add the filter to views. Either we decided that all views can be filtered along the same way/rules or we leave it. Bug 69200 is tracking this.

*** This bug has been marked as a duplicate of bug 69200 ***