Bug 224177 - SessionTestSuite should set org.eclipse.update.reconcile=false
Summary: SessionTestSuite should set org.eclipse.update.reconcile=false
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M7   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-26 14:32 EDT by Thomas Watson CLA
Modified: 2008-04-10 10:07 EDT (History)
2 users (show)

See Also:

Attachments
patch (1.29 KB, patch)
2008-03-26 14:35 EDT, Thomas Watson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2008-03-26 14:32:13 EDT 
If you run a testcase that extends SessionTestSuite then you will see several messages logged like the following:

!ENTRY org.eclipse.update.configurator 0 0 2008-03-26 13:28:11.312
!MESSAGE Could not install bundle plugins/org.eclipse.swt_3.4.0.v3435.jar   Bundle "org.eclipse.swt" version "3.4.0.v3435" has already been installed from: reference:file:/C:/dev/latest/eclipse/plugins/org.eclipse.swt_3.4.0.v3435.jar

It appears that simpleconfigurator is installing the bundles before update.configurator runs and update.configurator attempts to install the same bundles as simpleconfigurator.

org.eclipse.osgi.tests.util.AllTests is an example testcase that will demonstrate the issue.  Perhaps SessionTestSuite should set the system property org.eclipse.update.reconcile=false.  I imagine this would cause issues if for some reason simpleconfigurator is not used in the session tests.
Comment 1 Thomas Watson CLA 2008-03-26 14:35:48 EDT 
Created attachment 93659 [details]
patch

With this patch I no longer see the error messages when I run the tests locally from my workspace.  They also run much faster now :)  I am not if the automated tests during the build have the same issues when simpleconfigurator is used (or if simpleconfigurator is even used during session tests at build time).
Comment 2 John Arthorne CLA 2008-03-26 16:29:00 EDT 
Do you think this is important for M6? I'd like to defer until M7 if it's not causing serious problems.
Comment 3 Thomas Watson CLA 2008-03-26 16:35:07 EDT 
Fine for M7.  This is not causing serious issues at the moment.
Comment 4 DJ Houghton CLA 2008-04-03 16:46:27 EDT 
Released to HEAD.