Bug 223934 - [Viewers] StyledCellLabelProvider.COLORS_ON_SELECTION should be enabled on some platforms
Summary: [Viewers] StyledCellLabelProvider.COLORS_ON_SELECTION should be enabled on so...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-25 14:32 EDT by Markus Keller CLA
Modified: 2019-09-06 16:06 EDT (History)
3 users (show)

See Also:

Attachments
A possible fix (2.51 KB, patch)
2008-03-25 15:01 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-03-25 14:32:08 EDT 
StyledCellLabelProvider.COLORS_ON_SELECTION should be enabled by default on some platforms.

E.g. on the Mac and on Windows Vista, the selection foreground color is always the same as the unselected text foreground color, and text ranges that have a custom color keep this color even when selected (do Select All in a Java editor to see this). StyledCellLabelProvider should imitate the platform behavior by default.

The platform behavior could probably be determined by comparing the rgb values of SWT.COLOR_LIST_FOREGROUND and SWT.COLOR_LIST_SELECTION_TEXT.
Comment 1 Markus Keller CLA 2008-03-25 15:01:23 EDT 
Created attachment 93471 [details]
A possible fix
Comment 2 Martin Aeschlimann CLA 2008-03-25 15:19:39 EDT 
Steve, I have the 'no colors on selected items' opinion from you. Do you think 'colors on selected items on some platforms' make sense? Should we make it a configurable option?
Comment 3 Steve Northover CLA 2008-03-27 11:53:02 EDT 
Making it configurable gives you a way out if there is a problem.  The down side is increasing the number of preferences.  Also, colors can change when the user changes themes so you'd either have to listen for settings changes or better, test the colors every time and decide on the fly.
Comment 4 Boris Bokowski CLA 2009-11-26 09:55:54 EST 
Hitesh is now responsible for watching bugs in the [Viewers] component area.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:06:48 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.