Bug 223492 - Set worker thread's name for job execution to be job's name.
Summary: Set worker thread's name for job execution to be job's name.
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 M5   Edit
Assignee: Stefan Winkler CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
: 266249 (view as bug list)
Depends on: 528808
Blocks:
  Show dependency tree
 
Reported: 2008-03-21 09:16 EDT by Min Idzelis CLA
Modified: 2018-01-16 11:59 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Min Idzelis CLA 2008-03-21 09:16:12 EDT 
Build ID: Eclipse 3.4M5

Steps To Reproduce:
Currently the Worker Job thread pool for running Jobs has names set like Worker-X. Some profilers (like YourKit 7.0) now can do lock and monitor profiling. It groups the timing information by thread name. It would make debugging a LOT nicer if the name of the Worker Thread was set to the Name of the Job. Not only will this make profiling easier, but it will help find the right Thread in the Java debugger when looking for an executing Job. 

More information:
Comment 1 John Arthorne CLA 2008-06-27 15:36:49 EDT 
We explored setting worker thread names, but it results in confusion because there is no event sent to the debugger when a thread name changes, so it will always be showing a stale value. The result is worse than no name at all, because you can't trust that the name you see is not stale. See similar discussion in bug 135610.
Comment 2 John Arthorne CLA 2009-02-26 09:16:13 EST 
*** Bug 266249 has been marked as a duplicate of this bug. ***
Comment 3 Stefan Winkler CLA 2017-12-11 10:52:05 EST 
Attempting once more for this bug.

I often have the problem that I have a debug session of an Eclipse product which has >20 Worker threads in the pool and one Job is taking long time. After suspending, I have no way of telling which of the Workers is currently executing a job and which is currently idle and waiting for work.

Missing support in the JDT Debug View to update the shown thread names should not be the reason for not implementing this feature in Platform.

I'll provide a Gerrit Patch shortly.
Comment 4 Eclipse Genie CLA 2017-12-11 11:14:58 EST 
New Gerrit change created: https://git.eclipse.org/r/113176
Comment 5 Andrey Loskutov CLA 2017-12-14 17:53:49 EST 
(In reply to Eclipse Genie from comment #4)
> New Gerrit change created: https://git.eclipse.org/r/113176

I've voted -2 on the patch, and created bug 528808 which need to be fixed first. If you want the patch to be accepted, and this bug to be fixed, please consider to contribute to bug 528808 solution.
Comment 6 Lars Vogel CLA 2017-12-19 07:40:52 EST 
Thanks Stefan for the patch. As discussed on the hackathon, having Bug 528808 fixed would be desired so that this can be applied savely. Could you also work on Bug 528808?
Comment 7 Andrey Loskutov CLA 2017-12-19 07:52:31 EST 
(In reply to Lars Vogel from comment #6)
> Thanks Stefan for the patch. As discussed on the hackathon, having Bug
> 528808 fixed would be desired so that this can be applied savely. Could you
> also work on Bug 528808?

Bug 528808 has already a patch, which only waits for a review.
Comment 8 Lars Vogel CLA 2017-12-19 07:58:36 EST 
(In reply to Andrey Loskutov from comment #7)
> Bug 528808 has already a patch, which only waits for a review.

Thanks, not sure why I did not see it before. Maybe an out-of-date tab in my browser, which I used to "check".
Comment 10 Andrey Loskutov CLA 2017-12-22 05:39:56 EST 
Stefan, please add an entry to N&N.
Comment 11 Andrey Loskutov CLA 2018-01-16 11:59:38 EST 
(In reply to Andrey Loskutov from comment #10)
> Stefan, please add an entry to N&N.

Done via https://git.eclipse.org/r/115457