Bug 223232 - [results] Stack trace when generating perf results with I20080318-0800
Summary: [results] Stack trace when generating perf results with I20080318-0800
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2008-03-19 14:13 EDT by Kim Moir CLA
Modified: 2009-05-13 06:48 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Moir CLA 2008-03-19 14:13:18 EDT 
Stack trace when generating perf results with I20080318-0800
Comment 1 Frederic Fusier CLA 2008-03-19 14:42:44 EDT 
Kim, it seems that it's a database access issue. While connecting on line 396 of DB_Results in connect() method, I always get a SQLException: No suitable driver

The perf results generation was not designed to work without a DB connection and there's no specific protection while accessing DB to get the data, hence the NPE on the first array without any items... :-(

However, it seems that the connection issue does not come from the database itself as I can access it from the Results view I use to verify the performance results each week. I use it from a runtime workbench although the perf results generation uses a runtime applications extension.

As I'm not really an expert in this kind of launch config, I'll see if I can figure out what could be the difference between the working (runtime wkbch) and non-working (runtime application) DB access...
Comment 2 Frederic Fusier CLA 2008-03-19 14:46:54 EDT 
Note that I didn't get any trouble on maintenance stream database. I can connect to the DB from the runtime workbench as well as running the runtime application to generate the perf results.

Note also that when connection to the 3.4 DB, I didn't see any results for I20080318-0800 build... So, either the perf tests didn't really run or the results were not stored in database.
Comment 3 Frederic Fusier CLA 2008-03-20 06:02:31 EDT 
Hmm, it seems I didn't investigate deeply enough yesterday evening... In fact the exception also occurs on my runtime workbench. I was thinking it worked but I was only reading results stored locally! Sorry for that.

So, now it sounds more like a database issue. Maybe the network server is down for this database?
Comment 4 Frederic Fusier CLA 2008-03-20 06:24:50 EDT 
Oooops, forget my previous comment!!! Again, I didn't investigate enough... :-(
Sorry for the noise

The database connection looks OK. The SQLException occurs as we do not have the DB2 driver but use the cloudscape one instead. So, the first connection attempt fails but the second one succeeds!

Querying the database for all builds, does not show any 'I20080318-0800' item: so, finally, the problem comes from the fact that there's no results for this build! 

The conclusion is that perf results generation needs to be modified to report properly in the log the fact that the requested build has no performance results instead of raising a NPE... (and makes me become completely noisy!!!)
Comment 5 Frederic Fusier CLA 2008-03-20 12:51:45 EDT 
Note that there was no performance results stored for build I20080318-0800 due to bug 223372.
Comment 6 Philipe Mulet CLA 2008-05-23 04:29:18 EDT 
Please adjust the target milestone, so it does not point at a closed milestone in the past.
Comment 7 Frederic Fusier CLA 2009-05-13 06:48:12 EDT 
This has been fixed a while ago...