Bug 22214 - [CVS UI] Remote file gets retrieved 3 times
Summary: [CVS UI] Remote file gets retrieved 3 times
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 M5   Edit
Assignee: Boris Shingarov CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate, performance
Depends on:
Blocks:
 
Reported: 2002-08-06 14:02 EDT by Ruslan CLA
Modified: 2003-02-04 16:45 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan CLA 2002-08-06 14:02:20 EDT
I am comparing local file with CVS repository accessed through SSH protocol.
My internet connection at home is modem-based so
I can see - when I do Compare With -> Latest From Repository
file gets retrieved 3 times, making it 3 times slower:
 1. Displaying Progress Information
 2. After Progress Information dialog is off, but no CVS Compare tab show up
 3. In CVS Compare tab, when I double click (or press ENTER) on file.
Looks like too much to retrieve 3 times.
Comment 1 Andre Weinand CLA 2002-08-09 20:11:02 EDT
That seems to be a CVS (VCM) issue.
Comment 2 Kevin McGuire CLA 2002-08-12 12:41:50 EDT
investigate for 2.1
upped severity since performance related
Comment 3 Boris Shingarov CLA 2003-02-04 16:45:19 EST
Here is the CVS log of the scenario you describe:

== CUT ==
Valid-responses ok error M E Module-expansion Updated Template Set-static-
directory Notified Mod-time Valid-requests Copy-file Set-sticky Update-
existing Clear-static-directory Merged Checked-in Remove-entry Clear-sticky 
Created New-entry Removed
valid-requests
Valid-requests Root Valid-responses valid-requests Repository Directory Max-
dotdot Static-directory Sticky Checkin-prog Update-prog Entry Kopt Checkin-
time Modified Is-modified UseUnchanged Unchanged Notify Questionable Case 
Argument Argumentx Global_option Gzip-stream wrapper-sendme-rcsOptions Set 
expand-modules ci co update diff log rlog add remove update-patches gzip-file-
contents status rdiff tag rtag import admin export history release watch-on 
watch-off watch-add watch-remove watchers editors init annotate rannotate noop 
version
ok
Root /home/bshingar/testrepo1
CMD> cvs -n update -A -d "/JschTest/test/AllTestCase.java"
Global_option -n
Argument -A
Argument -d
Directory .
/home/bshingar/testrepo1/JschTest/test
Entry /AllTestCase.java/1.2/Wed Jan  8 21:11:40 2003//
Modified AllTestCase.java
u=rw,g=rw,o=r
642
Argument AllTestCase.java
Directory .
/home/bshingar/testrepo1/JschTest/test
update
M M AllTestCase.java
ok
RESULT> Status OKorg.eclipse.team.cvs.core code=0 ok null
Valid-responses ok error M E Module-expansion Updated Template Set-static-
directory Notified Mod-time Valid-requests Copy-file Set-sticky Update-
existing Clear-static-directory Merged Checked-in Remove-entry Clear-sticky 
Created New-entry Removed
valid-requests
Valid-requests Root Valid-responses valid-requests Repository Directory Max-
dotdot Static-directory Sticky Checkin-prog Update-prog Entry Kopt Checkin-
time Modified Is-modified UseUnchanged Unchanged Notify Questionable Case 
Argument Argumentx Global_option Gzip-stream wrapper-sendme-rcsOptions Set 
expand-modules ci co update diff log rlog add remove update-patches gzip-file-
contents status rdiff tag rtag import admin export history release watch-on 
watch-off watch-add watch-remove watchers editors init annotate rannotate noop 
version
ok
Root /home/bshingar/testrepo1
CMD> cvs log -r1.2 "AllTestCase.java"
Argument -r1.2
Directory .
/home/bshingar/testrepo1/JschTest/test
Entry /AllTestCase.java/1.2/Wed Jan  8 21:11:40 2003//
Is-modified AllTestCase.java
Argument AllTestCase.java
Directory .
/home/bshingar/testrepo1/JschTest/test
log
M 
M RCS file: /home/bshingar/testrepo1/JschTest/test/AllTestCase.java,v
M Working file: AllTestCase.java
M head: 1.2
M branch:
M locks: strict
M access list:
M symbolic names:
M keyword substitution: kv
M total revisions: 2;	selected revisions: 1
M description:
M ----------------------------
M revision 1.2
M date: 2003/01/08 21:11:39;  author: bshingar;  state: Exp;  lines: +11 -3
M *** empty log message ***
M =============================================================================
ok
RESULT> Status OKorg.eclipse.team.cvs.core code=0 ok null
== CUT ==

This shows that what happens when we double-click to open structured compare 
is a cvs log, not a file transfer.  Maybe we "accidentally" fixed the bug when 
we removed in-memory caching.