Bug 221998 - Ensure that OSGi-INF is included in build.properties
Summary: Ensure that OSGi-INF is included in build.properties
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Jacek Pospychala CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2008-03-09 21:24 EDT by Simon Archer CLA
Modified: 2008-03-28 14:43 EDT (History)
2 users (show)

See Also:

Attachments
patch (3.21 KB, patch)
2008-03-10 14:31 EDT, Jacek Pospychala CLA 		no flags Details | Diff
org.eclipse.pde.core.patch (6.61 KB, patch)
2008-03-10 21:13 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2008-03-09 21:24:02 EDT 
The folder OSGI-INF at the root of a bundle is mentioned numerous times in the OSGi spec.  For example, the Bundle-Localization header defaults to OSGI-INF/l10n/bundle.

It would be helpful if PDE could issue a warning if the OSGI-INF folder exists at the root of the project, yet is not included in the build.properties key bin.includes.  Forgetting to include important resources, such as OSGI-INF, is a common cause of problem for developers.

PDE currently does this for the META-INF folder, which clearly is always required.  Having this support for OSGI-INF would be helpful too.
Comment 1 Chris Aniszczyk CLA 2008-03-10 10:39:15 EDT 
For once I agree with you here with no qualms.

I'm going to tag the fix. For those willing to do the fix, check out BuildErrorReporter ;)
Comment 2 Simon Archer CLA 2008-03-10 10:53:07 EDT 
What no qualms, surely not!  Actually I'm not surprised that you're OK with this one, since you fixed bug 138260, which is similar to this one.  Thanks Chris.
Comment 3 Jacek Pospychala CLA 2008-03-10 14:31:13 EDT 
Created attachment 92070 [details]
patch

I believe we don't want to force users to include it even OSGI-INF/ folder it's empty.
Comment 4 Jacek Pospychala CLA 2008-03-10 14:33:15 EDT 
(In reply to comment #3)
> I believe we don't want to force users to include it even OSGI-INF/ folder it's
> empty.

hmm am faster than my keyboard :P

should be "I believe we don't want to force users to include OSGI-INF/ if it's empty."
Comment 5 Chris Aniszczyk CLA 2008-03-10 21:13:22 EDT 
Created attachment 92106 [details]
org.eclipse.pde.core.patch

I used this patch to motivate me to do some refactoring here...
Comment 6 Chris Aniszczyk CLA 2008-03-10 21:13:56 EDT 
Thanks Jacek!

> 20080310
Comment 7 Jacek Pospychala CLA 2008-03-28 14:43:37 EDT 
Verified in I20080325-0100