Bug 138260 - Enforce META-INF to be included in build.properties
Summary: Enforce META-INF to be included in build.properties
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.3 M1   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-24 16:24 EDT by Simon Archer CLA
Modified: 2006-07-18 13:10 EDT (History)
2 users (show)

See Also:

Attachments
org.eclipse.pde.ui.patch (1.39 KB, patch)
2006-07-18 12:20 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
org.eclipse.pde.ui.patch (1.89 KB, patch)
2006-07-18 12:57 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2006-04-24 16:24:33 EDT 
Using Eclipse 3.2 RC1

NOTE: This report is an ENHACEMENT, not a bug, so it should probably be left until after Eclipse 3.2 is released.

Neglecting to include META-INF in build.properties causes the following fatal error for the plugin:

  !ENTRY org.eclipse.update.configurator 2006-04-24 16:02:55.584
  !MESSAGE Plugin does not have a valid identifier: plugins/<id>_<version>/

Since all plugins are really OSGi bundles, and since OSGi requires every bundle to have a META-INF, it seems sensible for the PDE to verify that build.properties includes META-INF.  For Java projects the PDE already ensures that '.' is included in build.properties.

Ideally, if the project has no errors or warnings the resulting plugin/bundle should "just work".  A problem such as this should really be detected by the tooling.
Comment 1 Simon Archer CLA 2006-06-17 20:02:39 EDT 
Also see bug 147621 that is closely related to this problem in that it asks for build.properties validation.
Comment 2 Chris Aniszczyk CLA 2006-07-18 12:20:59 EDT 
Created attachment 46452 [details]
org.eclipse.pde.ui.patch

Appeasing Wassim... I was working in this area already so sorry if I over-stepped ;)
Comment 3 Wassim Melhem CLA 2006-07-18 12:48:11 EDT 
Upon inspection of the patch, it seems to be lacking two things:

1. META-INF/MANIFEST.MF is also acceptable in bin.includes
2. old-style plug-ins don't have a manifest.mf.  So we need to check the project first for the existing of this file before flagging it.  use WorkspaceModelManager.hasBundleManifest(...)
Comment 4 Chris Aniszczyk CLA 2006-07-18 12:57:37 EDT 
Created attachment 46457 [details]
org.eclipse.pde.ui.patch

#1 should be taken care of here
added support for #2

good deal
Comment 5 Wassim Melhem CLA 2006-07-18 13:10:56 EDT 
Patch released.  Thanks Chris.