Bug 147621 - Enforce Bundle-Localization folders/file to be included in build.properties
Summary: Enforce Bundle-Localization folders/file to be included in build.properties
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
: 206548 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-17 20:01 EDT by Simon Archer CLA
Modified: 2007-12-11 11:56 EST (History)
3 users (show)

See Also:
caniszczyk: review? (baumanbr)

Attachments
mylyn/context/zip (736 bytes, application/octet-stream)
2007-11-19 11:58 EST, Chris Aniszczyk CLA 		no flags Details
org.eclipse.pde.core.patch (3.15 KB, patch)
2007-11-29 21:36 EST, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (831 bytes, application/octet-stream)
2007-12-04 09:24 EST, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2006-06-17 20:01:33 EDT 
Using Eclipse 3.2 RC7

This bug is very closely related to bug 138260 in that it asks for PDE to ensure that files required by a bundle at runtime are included in build.properties.  The goal here is to ensure that the bundle is built accurately and does not surprise the developer at runtime.

The value for the Bundle-Localization manifest header describes a file, with an optional path, that points at the properties file containing localized string values.  It would be handy if the PDE could ensure that the localized file, and optional directory structure, be included in the build.properties.

Please remember that if the Bundle-Localization header is NOT present in the manifest the default localization value is "OSGI-INF/l10n/bundle".  This is described in section 3.2.1.8 of the OSGi R4 Core specification.  So, if Bundle-Localization is not present in the manifest AND OSGI-INF/l10n/bundle.properties exists then PDE should ensure that OSGI-INF/l10n/bundle.properties is included in build.properties.  This is easy to overlook.

Without this validation it will be possible to build a bundle that does not behave as expected.
Comment 1 Brian Bauman CLA 2007-10-16 19:10:30 EDT 
One addition to this, if the project is a 3.0 project, we need to remember to treat it accordingly (ie. plugin.properties).
Comment 2 Brian Bauman CLA 2007-10-16 19:10:41 EDT 
*** Bug 206548 has been marked as a duplicate of this bug. ***
Comment 3 Chris Aniszczyk CLA 2007-11-19 11:58:41 EST 
Adding a context to assist bugday people.
Comment 4 Chris Aniszczyk CLA 2007-11-19 11:58:50 EST 
Created attachment 83252 [details]
mylyn/context/zip
Comment 5 Chris Aniszczyk CLA 2007-11-29 21:36:44 EST 
Created attachment 84128 [details]
org.eclipse.pde.core.patch

Here's a first stab at this code before I lose it in my workspace. Needs more testing before we release it.
Comment 6 Chris Aniszczyk CLA 2007-11-29 21:40:06 EST 
Feel free to take a look at this code when you have time Brian. I hacked this up on the airplane and it seems to work in the important cases.
Comment 7 Chris Aniszczyk CLA 2007-12-04 09:24:10 EST 
Ok, went through the test pass. Committing to HEAD in Simon's honor.
Comment 8 Chris Aniszczyk CLA 2007-12-04 09:24:15 EST 
Created attachment 84415 [details]
mylyn/context/zip
Comment 9 Simon Archer CLA 2007-12-07 13:30:47 EST 
Thank you, Chris.  Add one to my frosty beverage tab.  ;-)
Comment 10 Brian Bauman CLA 2007-12-11 11:56:53 EST 
verified on I20071211-0010