Bug 221649 - [Import/Export] ZipFileImportWizard has no option to change the FILE_IMPORT_MASK
Summary: [Import/Export] ZipFileImportWizard has no option to change the FILE_IMPORT_MASK
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3.1   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2008-03-06 07:21 EST by Oliver Schäfer CLA
Modified: 2008-03-17 05:59 EDT (History)
0 users

See Also:

Attachments
Example patch (3.30 KB, patch)
2008-03-11 10:20 EDT, Oliver Schäfer CLA 		no flags Details | Diff
Example patch 2 (3.32 KB, patch)
2008-03-11 10:43 EDT, Oliver Schäfer CLA 		no flags Details | Diff
Example (4.06 KB, application/octet-stream)
2008-03-13 12:06 EDT, Tod Creasey CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Schäfer CLA 2008-03-06 07:21:31 EST 
Build ID: M20080221-1800

This is a request for enhancement. 
The file import mask is defined in WizardArchiveFileResourceImportPage1 which is not public API. So it would be nice to have a setter mechanism on the ZipFileImportWizard.

Would increase usability extending ZipFileImportWizard.

More information:
There was a request years ago: bug#17958
Comment 1 Oliver Schäfer CLA 2008-03-11 09:29:57 EDT 
I could provide a patch on these two classes, if this would help in figuring out.
Comment 2 Tod Creasey CLA 2008-03-11 09:33:45 EDT 
Please do,
Comment 3 Oliver Schäfer CLA 2008-03-11 10:20:56 EDT 
Created attachment 92166 [details]
Example patch
Comment 4 Oliver Schäfer CLA 2008-03-11 10:27:55 EDT 
Sorry, but createFileImportMask should return null in its default implementation.
Comment 5 Oliver Schäfer CLA 2008-03-11 10:43:54 EDT 
Created attachment 92169 [details]
Example patch 2

Removed a typo and return null as default in createFileImportMask
Comment 6 Tod Creasey CLA 2008-03-12 16:42:52 EDT 
Patch released with some modifications for build >20080312
Comment 7 Tod Creasey CLA 2008-03-13 12:06:12 EDT 
Created attachment 92464 [details]
Example
Comment 8 Oliver Schäfer CLA 2008-03-13 12:36:41 EDT 
Thanks for applying the patch, this is so helpful. I will verify this issue with the next integration build.
Comment 9 Oliver Schäfer CLA 2008-03-17 05:59:26 EDT 
Verfied with N20080316-2000.