Bug 221596 - [Viewers] Ganymede UI refresh a lot slower than Europa
Summary: [Viewers] Ganymede UI refresh a lot slower than Europa
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.4   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-03-05 16:43 EST by Michael OBrien CLA
Modified: 2008-10-09 15:30 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael OBrien CLA 2008-03-05 16:43:42 EST
Hi,
   This is a bit minor but I have noticed a very large performance degradation when scrolling in Ganymede 3.4 M5 (with all pluggins including WTP3) as opposed to the latest Europa 3.3.1.1.
I don't think it is the Windows graphics library as half the pane refreshes instantly and it is the lower half that takes time - possibly HD latency?

   If you scroll a large number of java files in a navigator pane in Europa it is near instant, but in Ganymede the list takes about 0.25 sec to scroll.

Reproduction
-----------------
Windows Vista SP1, HP Core 2 Quad 2.4Ghz 3Gb Ram
I can run 2 separate copies of Ganymede along 1 copy of Europa fine.
The ganymede versions show the slow scrolling but the europa version is very fast when all 3 eclipse.exe versions are running simultaneously.

If you need any other info, mail me and I will provide it.

btw: Ganymede is running very well with WTP3 and seems to be more stable than Europa 3.3.1.1 as i do not get the occassional JVM crash with the same workspace config when running 3.4 M5.

thank you
Comment 1 Kim Horne CLA 2008-03-06 11:37:56 EST
Perhaps a fallout from the use of owner draw?  Do we have any performance numbers for this?
Comment 2 Boris Bokowski CLA 2008-03-06 12:15:23 EST
Can you turn off colored labels (Window > Preferences > Java > Appearance, uncheck "Show colored labels") and try again?
Comment 3 Michael OBrien CLA 2008-03-11 12:03:58 EDT
Flag set to off - sorry, no change

But, these flags only affected my Hiearchy sub-pane and did not cause any visible changes to the navigator pane - which has no annotations like ": void - java.lang.Object" on the file list.

Note: the "Package Explorer" view expanded out to show all java files does not have this problem, only the "Navigator" view is slow (and seems to be independent of the depth of the package tree)
Comment 4 Boris Bokowski CLA 2008-03-11 12:05:59 EDT
Tom or Tod, do you have any ideas what could be causing this?
Comment 5 Thomas Schindl CLA 2008-03-11 12:16:06 EDT
... we haven't changed much inside the JFace-Viewers in 3.4 and my first reaction was also to point to owner draw which doesn't seem to be the problem from what is said above. I think we need to profile the code to see where the time is spent.
Comment 6 Boris Bokowski CLA 2008-03-11 12:48:00 EDT
I won't be able to look at this until after EclipseCon, but I think it's important to find out what's happening.
Comment 7 Tod Creasey CLA 2008-03-11 13:01:57 EDT
Owner draw is running with or without the colouring correct? I suspect it is the callbacks that we are getting from SWT being served - this is also an issue for VIRTUAL tables.

I suspect we are filling in more often then we need to.
Comment 8 Steve Northover CLA 2008-03-11 14:40:40 EDT
> Owner draw is running with or without the colouring correct? 

This should not be the case.  If you are not doing custom draw, then everything should be as fast as it was without.  Note:  When you turn off "Show colored labels", you will need to restart to IDE to really get rid of custom draw.
Comment 9 Philipe Mulet CLA 2008-05-23 04:29:18 EDT
Please adjust the target milestone, so it does not point at a closed milestone in the past.
Comment 10 Boris Bokowski CLA 2008-05-23 09:58:34 EDT
Marking for investigation, but I am pessimistic that we can do much about it for 3.4 even if we find out that the refresh is indeed slower.
Comment 11 Boris Bokowski CLA 2008-05-29 17:07:30 EDT
I am out of time to do anything about this for 3.4.

As a workaround, you should be able to get the performance back by disabling colored labels, either from the General>Appearance preference page, or via plugin_customization.ini, or by setting the preference programmatically:

IWorkbenchPreferenceConstants.USE_COLORED_LABELS

Marking for 3.4.1 (and helpwanted).
Comment 12 Boris Bokowski CLA 2008-05-29 17:18:22 EDT
(In reply to comment #3)
> Note: the "Package Explorer" view expanded out to show all java files does not
> have this problem, only the "Navigator" view is slow (and seems to be
> independent of the depth of the package tree)

Sorry, while re-reading this bug I found the above which says that owner draw is not the culprit. I have tested with a folder containing just under 4000 folders and files and could not reproduce the problem. Are you sure it was the Navigator view (and not for example the Project Explorer view)? Do you have steps with which I can reproduce? I was only using the base SDK but that should not make a difference for the Navigator view. (It would make a difference for the Project Explorer view though.)
Comment 13 Boris Bokowski CLA 2008-08-25 22:51:18 EDT
Removing target milestone due to lack of response. It is too late to do anything about this for 3.4.1.
Comment 14 Michael OBrien CLA 2008-10-09 15:30:47 EDT
Sorry for the lack of updates.
This no longer occurrs on production ganymede 3.4 RCx