Bug 221378 - [ssh] Update JSch to version 0.1.37
Summary: [ssh] Update JSch to version 0.1.37
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 221001
Blocks: 191263 204705 208912 220853 224799
  Show dependency tree
 
Reported: 2008-03-04 14:11 EST by Martin Oberhuber CLA
Modified: 2008-05-07 04:47 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-03-04 14:11:59 EST
+++ This bug was initially created as a clone of Bug #191263 +++

A (small but important) number of bugs have been identified in JSch 0.1.31 which is shipping with Eclipse 3.3 - including bug 191263 (platform-cvs), bug 204705 (dsdp-tm), bug 208912 (dsdp-tm), bug 220853 (dsdp-tm)

JSch should be upgraded to version 0.1.37 for Ganymede. Corresponding CQ has been approved already as per
   http://dev.eclipse.org/ipzilla/show_bug.cgi?id=2014

So JSch-0.1.37 should be added to Orbit and included in Platform builds.
Comment 1 Atsuhiko Yamanaka CLA 2008-03-05 01:49:24 EST
(In reply to comment #0)
> So JSch-0.1.37 should be added to Orbit and included in Platform builds.

As far as I have recognized, to push it into Eclipse Platform,
we need the approval by EMO(part of which would involve the creation
of the required 'about.html' file).
I don't know if it is in the process or not.  If not, I don't know
how to start the process(request for the approval).  
For previous Eclipse Platforms, Michael had worked on it.  
Any suggestions are welcome.
Comment 2 Martin Oberhuber CLA 2008-03-05 04:52:20 EST
I have obtained permission for checking JSch-0.1.37 into Orbit as per
    http://dev.eclipse.org/ipzilla/show_bug.cgi?id=2158
and have committed it to the Orbit Repository,
    /cvsroot/tools, org.eclipse.orbit/com.jcraft.jsch,  branch=v0_1_37

I took and adapted the about.html as well as parts of the Manifest meta-info from JSch-0.1.31, I'm now waiting for the Orbit Build to complete such that I can download and test the bundle, and the Eclipse Platform PMC to approve re-use in the Platform as per
    https://dev.eclipse.org/ipzilla/show_bug.cgi?id=2014#c22

For Orbit build Status you can follow this if you want:
    http://build.eclipse.org:9777/cruisecontrol/buildresults/orbit-I
Comment 3 Martin Oberhuber CLA 2008-03-05 13:30:16 EST
JSch-0.1.37 is built in Orbit and available from
http://download.eclipse.org/tools/orbit/committers/drops/I20080305144804/

Eclipse Platform PMC has allowed inclusion in Platform as per 
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=2014#c24

Kim or Michael can you please update the Platform CVS Feature to include the new JSch as soon as a stable Orbit build is declared.
Comment 4 Martin Oberhuber CLA 2008-03-12 08:16:31 EDT
An Orbit I-build which includes JSch-0.1.37 has been promoted to downloads:
http://download.eclipse.org/tools/orbit/downloads/drops/I20080307200012/

This I-build will remain available for long. Please update Platform Features to use JSch from this build, and release for next Platform I-build.
Comment 5 Kim Moir CLA 2008-03-12 08:27:54 EDT
Yes, I will update to a newer orbit build this week.  I'm just waiting for all the issues with the I-build to be sorted out first.
Comment 6 Kim Moir CLA 2008-03-23 17:14:05 EDT
released for I20080323-2000.
Comment 7 Martin Oberhuber CLA 2008-04-23 14:28:59 EDT
For everybody's info, JSch-0.1.38 has been released:
http://sourceforge.net/mailarchive/forum.php?thread_name=200804221521.AAA16510%40jcraft.com&forum_name=jsch-users

Changes since version 0.1.37:
1)  bugfix: NPE should not be thrown at unexpeced session drop. FIXED.
2)  bugfix: AIOOBE at Session#connect(). FIXED.
3)  bugfix: Even if 'true' is given for Channel#setOutputStream(
       OutputStream out, boolean dontclose) as the second paramter,
       'out' will be closed. FIXED.
4)  change: 'examples/Sftp.java' has been modified to demonstrate
       ChannelSftp#realpath(String path)
5)  change: setEnv(Hashtable env) for exec and shell channels have been
       marked as @deprecated
6)  feature: setEnv(String name, String value) has been added to exec 
       and shell channels.
7)  feature: setEnv(byte[] name, byte[] value) has been added to exec
       and shell channels.
8)  feature: ChannelSftp#realpath(String path) has been added.
9)  feature: ChannelExec#setCommand(byte[] command) has been added.
10) feature: com.jcraft.jsch.ChannelSftp.LsEntry has implemented 
       java.lang.Comparable
11) feature: Session#getServerAliveInterval(), Session#getServerAliveCountMaX()
       have been added.

For us, fixes (1) and (7) are interesting though not a "must have" for Ganymede. Is anybody else interested such that I should go and file an IPZilla / Orbit request? Is it even realistic to get 0.1.38 in for Ganymede?

My personal take is that I'd like to go and try getting it into Orbit, then we can still decide whether the Platform's going to adopt it out of Orbit or not. Sounds reasonable?
Comment 8 Kim Moir CLA 2008-04-23 14:42:46 EDT
Martin, I think it would be advisable to ask this question on the orbit mailing list for a wider audience. I haven't heard anything about us adopting the newer version but others will know more :-)