Bug 220815 - security manager causes 200% performance regression
Summary: security manager causes 200% performance regression
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard: Fixed in 1.0M7
Keywords: performance
Depends on:
Blocks:
 
Reported: 2008-02-28 14:53 EST by James Sutherland CLA
Modified: 2022-06-09 10:22 EDT (History)
1 user (show)

See Also:

Attachments
patch (7.12 KB, patch)
2008-04-22 10:57 EDT, James Sutherland CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Sutherland CLA 2008-02-28 14:53:25 EST 
If a security manager is set, our performance degrades by 200%.  This is because of our doPriviledge.  Currently our test scripts set a security manager by default.

We should not enable doPrivilege by default if a security manager is set, a system property should be required to enable it.

We need to know what environments set this by default, it seems that OC4J, or probably OracleAS may set this by default.  Most likely other servers set this as well giving us 200% worse performance than other products.

Also the current system property to disable it was not renamed and is still oracle.toplink.
Comment 1 James Sutherland CLA 2008-04-22 10:56:58 EDT 
SVN: Checkin bug#220815 don't use do privilege unless set

Changes:
- Changed the doPrivilege to only be used if the system property is set, and renamed property from toplink to "eclipselink.secuirty.usedoprivilege".

Code Review: Tom (pending)
Comment 2 James Sutherland CLA 2008-04-22 10:57:18 EDT 
Created attachment 97027 [details]
patch
Comment 3 James Sutherland CLA 2008-04-22 11:00:08 EDT 
This will avoid people accidentally loosing 200% performance when using a security manager.  Since additional configuration is required to use doPrivilege requiring the property to be set should be no big issue.

OC4J may need to set this when integrating with EclipseLink when using a security manager.
Comment 4 James Sutherland CLA 2008-05-20 15:06:35 EDT 
closing
Comment 5 Eclipse Webmaster CLA 2022-06-09 10:22:37 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink