Bug 220557 - [StatusHandling] Handling of jobs statuses needs polishing
Summary: [StatusHandling] Handling of jobs statuses needs polishing
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.5 M6   Edit
Assignee: Krzysztof Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 193110 223074
  Show dependency tree
 
Reported: 2008-02-27 09:46 EST by Krzysztof Daniel CLA
Modified: 2018-09-22 12:50 EDT (History)
5 users (show)

See Also:


Attachments
Idea (11.15 KB, patch)
2008-02-27 09:49 EST, Krzysztof Daniel CLA
no flags Details | Diff
mylyn/context/zip (47.11 KB, application/octet-stream)
2008-02-27 09:49 EST, Krzysztof Daniel CLA
no flags Details
Another fix proposition (27.70 KB, patch)
2008-03-13 08:21 EDT, Krzysztof Daniel CLA
no flags Details | Diff
mylyn/context/zip (65.09 KB, application/octet-stream)
2008-03-13 08:21 EDT, Krzysztof Daniel CLA
no flags Details
Patch updated to HEAD (30.06 KB, application/octet-stream)
2008-03-19 13:42 EDT, Tod Creasey CLA
no flags Details
Fix proposition (still under testing) (22.40 KB, patch)
2008-10-28 11:45 EDT, Krzysztof Daniel CLA
no flags Details | Diff
Another approach (16.15 KB, patch)
2009-01-13 07:05 EST, Krzysztof Daniel CLA
no flags Details | Diff
Patch (29.22 KB, patch)
2009-01-13 07:12 EST, Krzysztof Daniel CLA
no flags Details | Diff
polished patch (16.80 KB, patch)
2009-01-15 07:22 EST, Krzysztof Daniel CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Daniel CLA 2008-02-27 09:46:51 EST
It is possible to pass StatusAdapters with such property (from IProgressConstants), but it is impossible to show those errors to the user (and user may want to see them).

Currently it is possible to show those errors only using another StatusAdapter as a trigger.
Comment 1 Krzysztof Daniel CLA 2008-02-27 09:49:35 EST
Created attachment 90858 [details]
Idea

is that good direction?
Comment 2 Krzysztof Daniel CLA 2008-02-27 09:49:40 EST
Created attachment 90859 [details]
mylyn/context/zip
Comment 3 Krzysztof Daniel CLA 2008-03-13 08:21:03 EDT
Created attachment 92423 [details]
Another fix proposition
Comment 4 Krzysztof Daniel CLA 2008-03-13 08:21:09 EDT
Created attachment 92424 [details]
mylyn/context/zip
Comment 5 Krzysztof Daniel CLA 2008-03-18 10:32:23 EDT
This bug contains API changes.
Comment 6 Tod Creasey CLA 2008-03-19 13:42:52 EDT
Created attachment 92939 [details]
Patch updated to HEAD

Here is the patch updated to the contents of HEAD. I think there is too much going on here for us to consider such a large change this late in the game for M6.
Comment 7 Krzysztof Daniel CLA 2008-03-19 16:31:25 EDT
Tod, I talked to Szymon, and indeed this is too big change. However we wondered if manipulating only the StatusManager (preferably one  new method would be acceptable)?
Comment 8 Szymon Brandys CLA 2008-03-23 20:31:02 EDT
Sorry Krzysztof. It is too late to introduce this change in M6.
Comment 9 Krzysztof Daniel CLA 2008-08-06 06:47:56 EDT
It is necessary to decouple StatusManager from Jobs in general. StatusManager should not have a lot of imports.
Comment 10 Krzysztof Daniel CLA 2008-10-27 06:33:46 EDT
Szymon,
I have hit quite serious obstacle in this bug - 'Progress' view. It duplicates some of SH functionality (display jobs with their statuses and suggested actions) and may cause some inconsistency especially when it comes to *deleting* finished jobs.

Progress view takes input from ProgressManager and is completely independent from SH framework and it handles deferred statuses correctly. Delegating that functionality to SH would cause Progress View to stop displaying finished jobs - this is rather big change in UI and we should think twice before making any step in that direction.

Another thing is that finished job returns status, so when an error occurs we could receive a couple of Job statuses and one error. It will be confusing to the user.

I believe that the best option right now is to plug SH into progress, so when deferred status arrives, progress notification displays red cross.
Comment 11 Krzysztof Daniel CLA 2008-10-28 11:45:25 EDT
Created attachment 116308 [details]
Fix proposition (still under testing)
Comment 12 Krzysztof Daniel CLA 2008-11-04 10:33:51 EST
Need help!

This bug is not going to be easy one - there is a  huge compatibility gap: 

it is necessary to introduce new API to get rid off progress API in StatusManager.
But if we remove that API it is mandatory for handlers to use new API.
Old handlers do not use it - so we need to maintain old functionality => progress API stays.

Am I missing something?

 
Comment 13 Krzysztof Daniel CLA 2008-11-28 04:24:08 EST
Removing target milestone as this bug seems to be impossible to fix - we cannot remove progress usage as we need to maintain backward compatibility.
Comment 14 Krzysztof Daniel CLA 2009-01-13 07:05:28 EST
Created attachment 122403 [details]
Another approach

I think this is good solution.
Comment 15 Krzysztof Daniel CLA 2009-01-13 07:12:36 EST
Created attachment 122404 [details]
Patch
Comment 16 Krzysztof Daniel CLA 2009-01-15 07:22:00 EST
Created attachment 122659 [details]
polished patch
Comment 17 Krzysztof Daniel CLA 2009-01-15 09:36:34 EST
I have released the latest patch. StatusManager does not depend on ProgressManager anymore.

To adress support for deferred statuses separate bug will be opened.
Comment 18 Boris Bokowski CLA 2009-03-11 12:10:06 EDT
Krzysztof, can you please verify this bug?
Comment 19 Krzysztof Daniel CLA 2009-03-12 08:38:18 EDT
verified in N20090307