Bug 220109 - [refactoring] Add a PDEDeleteParticipant
Summary: [refactoring] Add a PDEDeleteParticipant
Status: CLOSED WONTFIX
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: bugday, helpwanted
: 127169 173064 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-02-24 15:34 EST by Benjamin Cabé CLA
Modified: 2019-09-09 02:29 EDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Cabé CLA 2008-02-24 15:34:06 EST
When you delete your Activator class, when you delete an exported package etc., MANIFEST.MF isn't updated.
When you delete a resource that is included in build.properties, the file isn't updated.

PDE should implement a DeleteParticipant to deal with refactorings implied by resource deletion.
Comment 1 Chris Aniszczyk CLA 2008-02-24 15:50:57 EST
good call!

Oh boy, people are getting spoiled by PDE and your work Benjamin ;)
Comment 2 Chris Aniszczyk CLA 2008-05-08 11:02:37 EDT
We will look at this in 3.5
Comment 3 Chris Aniszczyk CLA 2008-05-08 11:03:39 EDT
*** Bug 127169 has been marked as a duplicate of this bug. ***
Comment 4 Chris Aniszczyk CLA 2008-05-08 11:04:41 EDT
*** Bug 173064 has been marked as a duplicate of this bug. ***
Comment 5 Markus Keller CLA 2008-05-08 11:23:55 EDT
Note that bug 127169 was about deleting something *inside* a plugin.xml, so a DeleteParticipant will probably not catch it if a user deletes an extension point in a plugin.xml.

Builders like PDE's Plug-in Manifest Builder are typically not implemented as refactoring participants, since participants are only notified of explicit refactoring actions. You should rather implement a resource change listener (and maybe a Java model listener) to implement incremental builds correctly.
Comment 6 Darin Wright CLA 2009-04-06 14:02:35 EDT
Not planned for 3.5
Comment 7 Eclipse Webmaster CLA 2019-09-06 16:03:52 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 8 Julian Honnen CLA 2019-09-09 02:29:03 EDT
Please remove the stalebug flag, if this issue is still relevant and can be reproduced on the latest release.