Community
Participate
Working Groups
HEAD The AbstractInformationControl needs to be modified in order to serve as super class for the BrowserInformationControl.
Note that the resize grip from the BIC needs to be moved to the AIC.
Created attachment 90336 [details] step 1 First step: Get rid of pop up dialog and move add resize handler from BIC
Sorry, bad patch, need to solve this first: + data.widthHint= 20;//fgScrollBarSize.x;
Created attachment 90349 [details] step 1
Created attachment 90639 [details] step 1.5 Improvements w.r.t step 1: - Documented nontrivial implementations of IICE* methods (e.g. that computeSizeConstraints uses dialog font, whether subclasses must extend setFocus(), ...) - fixed setFocus() such that subclasses usually don't have to extend - reverted API break (bugs 120547 again) - only implementeor of setInformation can implement hasContents - additional text widget styles didn't get through to DIC#createContent(..) (callback in constructor of AIC while DIC's fields not yet initialized) - removed unnecessary computeTrim(Rectangle) TODO: - Implement IInformationControlExtension{2,4} - deprecate setInformation(String)? - Decide on strategy to deprecate constructors of DIC that take styles. This is currently rather messy for clients. Should just support 2 styles (resizable / tooltip-like). Need to decide about whether to use SWT.WRAP (see FIXME in DIC)
I've committed a modified version of the patch with new constructors and deprecated the old ones. Also adapted all clients to those new constructors. Remaining issue: move BIC under the AIC. This is something nice for Markus ;-)
Created attachment 90844 [details] DIC API
Created attachment 90952 [details] Step 3 Addresses all remaining issues.
Finally fixed. Committed slightly modified patch to HEAD. Available in builds > N20080228-0010.
