Community
Participate
Working Groups
The new control for working sets introduced by bug 209721 greatly simplifies the code of ImportProjectSetMainPage class. However, there is a minor issue: Initially, when there has been no working sets used before, are the selected ones don't exist anymore the Working Sets field will be empty. IMO having the "Add project to working set" button checked and empty list of working sets should disable the "Next/Finish" button. Or at least there should be a message about it. At this moment, when the user clicks Finish imported projects will be added no *none* working sets (ie won't be added to any working set). Additionally, the one of the label in the new control say "Add project to working set" which is not always true as a project set may contain couple of projects.
Created attachment 90168 [details] Screen shot
I agree with Tomasz, "Next" and "Finish" buttons should be disabled when user tries to add a project to a working set while no working set is on the list. While reproducing the bug I found another minor issue. If there is a path in "File name" history the combo box is initialized with this path. This happens also when the path points to a nonexistent file resulting in invalid initialization state. There is no common approach to this problem in other wizards. However some of them don't validate the history and don't initialize the "File name" combo (to select anything from history you have to expand the combo box). This approach seems most reasonable to me since it's consistent (combo never gets initialized) and doesn't result in invalid initialization. The build used is eclipse-SDK-N20080706-2000-win32.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
