Community
Participate
Working Groups
-- Created from Comment -- URL: https://bugs.eclipse.org/bugs/show_bug.cgi?id=216150 Comment: 5 Frank: this bug is about sorting in the Search view, not Task List. However, it would be great if you could make a new bug for your additional Task List sorting, because there have been some requests for that as well. Regarding this approach, I have a bit of a usability concern with your approach though, because some might have trouble understanding the word "Level", and because doubly-nested menus are hard to use. What if the menu was? * First Sort by -> full list of sorters * Then Sort by -> full list of sorters Btw, if you're interested in providing a patch for this bug that would be great too. What we're after is that no matter what primary sort order is chosen in the Search view, there should be a second sort order that's by ID and description (with the same semantics as in the Task List).
*** Bug 219542 has been marked as a duplicate of this bug. ***
*** Bug 219543 has been marked as a duplicate of this bug. ***
*** Bug 219541 has been marked as a duplicate of this bug. ***
Created attachment 90402 [details] patch
Created attachment 90403 [details] mylyn/context/zip
Frank, it would be great if you'd add a tests for TaskListTableSorter class. See existing TableSorterTest.
Created attachment 90581 [details] Patch with JUnit Test I add test for sort by Priority and then by Summary
Created attachment 90582 [details] mylyn/context/zip
Rob: please review next week (after we're all done with 2.3).
Created attachment 94449 [details] Bookmarks sorting dialog After trying the ui out first hand, perhaps we should consider using a single "Sorting..." menu option that opens a dialog similar to the Bookmarks (legacy) view's. Mik, what are your thougths on this?
Created attachment 94974 [details] alternative Patch Here the patch with a Dialog for setting the sortorder (as in comment 10).
Created attachment 94975 [details] mylyn/context/zip
Created attachment 94976 [details] corrected Version of alternative Patch Sorry I did not include the test.
Created attachment 94977 [details] mylyn/context/zip
*** Bug 224721 has been marked as a duplicate of this bug. ***
Just a couple nits remaining on this one Frank: *The dialog shell needs a title * the action title should be Sort... * need to ensure that the second level sort is persisted between workbench sessions (i.e. if sort by summary is chosen as the second level, upon restarting it should still be the case)
Created attachment 97109 [details] updated patch
Created attachment 97531 [details] updated patch Rob, I did not found the changes that you described in comment 16 and 17 so I create a new patch.
Created attachment 97532 [details] mylyn/context/zip
Frank: could you attach a screenshot?
Created attachment 98030 [details] screanshot Here the screanshot from my Mac. I know that this dialog is not Mylyn like but I am nos so good in UI Design.
Great stuff Frank. Little nits: * "Sortorder of the Task List" -> TaskListView.LABEL_VIEW + " Sorting" * "Sort by" -> "Sort order:" * "Date_Created" -> "Date Created"
Created attachment 98540 [details] updated Patch corrections from comment 22 included.
Created attachment 98541 [details] mylyn/context/zip
Frank, I've got some merge errors on TaskListView and TaskListTableSorter... any chance you could recut this patch and I'll try to get it applied before things change again (no promises though considering the dynamic nature of things lately). :)
(In reply to comment #25) > Frank, I've got some merge errors on TaskListView and TaskListTableSorter... any > chance you could recut this patch and I'll try to get it applied before things > change again (no promises though considering the dynamic nature of things > lately). :) Yes, but I first have to finish the setup of my new MacBook Pro (actually I must install the needed Pearl Modules for Bugzilla). Hope that I can finish this this night.
Created attachment 98951 [details] updated patch as requested by comment 25
Created attachment 98952 [details] mylyn/context/zip
Great! Patch applied, ip log updated.
