Bug 219246 - Strange exception from info system
Summary: Strange exception from info system
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Geclipse (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nick Tsioutsias CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 219594 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-02-17 04:48 EST by Mathias Stümpert CLA
Modified: 2014-01-09 16:15 EST (History)
2 users (show)

See Also:


Attachments
Patch for eu.geclipse.info (22.44 KB, patch)
2008-02-18 10:24 EST, Nick Tsioutsias CLA
no flags Details | Diff
Patch for eu.geclipse.info (32.38 KB, patch)
2008-02-19 03:07 EST, Nick Tsioutsias CLA
no flags Details | Diff
Patch for eu.geclipse.glite.info (17.70 KB, patch)
2008-02-19 03:08 EST, Nick Tsioutsias CLA
no flags Details | Diff
Patch for eu.geclipse.info (32.66 KB, patch)
2008-02-19 06:24 EST, Nick Tsioutsias CLA
no flags Details | Diff
Patch for eu.geclipse.info (781 bytes, patch)
2008-02-20 10:11 EST, Nick Tsioutsias CLA
no flags Details | Diff
Patch for eu.geclipse.info (3.98 KB, patch)
2008-02-20 10:22 EST, Nick Tsioutsias CLA
aog-ecl: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Stümpert CLA 2008-02-17 04:48:13 EST
When starting g-Eclipse from my home network I get the following exception directly after startup:

java.lang.NullPointerException
	at eu.geclipse.info.Activator$1.run(Activator.java:72)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
	
This exception says nothing so I can say nothing about the reasons of it. Nevertheless at least the info system seems to be able to do its work since I can see all resources out there.
Comment 1 Ariel Garcia CLA 2008-02-17 08:10:08 EST
One for you Nick. 

I guess   igp.getVO()    is returning null  in Activator.java:72 ... strange, shouldn't all children of GridMoldelRoot necessarily have a VO, Mathias?

Uhm, while we are at it Nick, please move Activator to a .internal package :)
Comment 2 Mathias Stümpert CLA 2008-02-17 08:21:47 EST
> I guess   igp.getVO()    is returning null  in Activator.java:72 ... strange,
> shouldn't all children of GridMoldelRoot necessarily have a VO, Mathias?

Not necessarily. There are a few cases where this does not hold. For instance the hidden project does not have a VO and therefore all its children don't have one, too. Furthermore it may happen with wrapped elements that in some circumstances they do not have a VO. For instance the Gria services are not VO specific but global. Within the Gria VO they are wrapped into VO specific wrappers. But if for any case you access the wrapped element here it does not have a VO.

There may be other cases where there is no VO, don't know if I remebered all from scratch now...
Comment 3 Nick Tsioutsias CLA 2008-02-18 10:22:17 EST
I have created a patch where I check if getVO() returns null. Mathias, tell me if you still have that exception.
Comment 4 Nick Tsioutsias CLA 2008-02-18 10:24:00 EST
Created attachment 89986 [details]
Patch for eu.geclipse.info

I am still not able to get the option to set the patch root when I create a svn patch. I am using subeclipse.
Comment 5 Nick Tsioutsias CLA 2008-02-19 03:07:48 EST
Created attachment 90035 [details]
Patch for eu.geclipse.info

This clears some middleware specific code in GlueCE and GlueService as well. I created some new classes under eu.geclipse.glite.info.glue that extend the glue classes and I added there the glite specific code.
Comment 6 Nick Tsioutsias CLA 2008-02-19 03:08:14 EST
Created attachment 90036 [details]
Patch for eu.geclipse.glite.info
Comment 7 Nick Tsioutsias CLA 2008-02-19 06:24:33 EST
Created attachment 90053 [details]
Patch for eu.geclipse.info

Fixed a small bug. An null pointer exception after double clicking in the tree shown in the glue info view.
Comment 8 Mathias Stümpert CLA 2008-02-20 09:44:37 EST
I applied the last two patches assuming the first two are obsolete. Nevertheless I still get the same exception when starting g-Eclipse.
Comment 9 Nick Tsioutsias CLA 2008-02-20 10:11:13 EST
Created attachment 90187 [details]
Patch for eu.geclipse.info

The null check I (thought I)had made is not there. I added it and made a new patch. All the other patches are obsolete now.
Comment 10 Nick Tsioutsias CLA 2008-02-20 10:22:08 EST
Created attachment 90191 [details]
Patch for eu.geclipse.info

Sorry for posting so many patches for this bug. Only this patch needs to be installed now.
Comment 11 Ariel Garcia CLA 2008-02-20 12:01:13 EST
*** Bug 219594 has been marked as a duplicate of this bug. ***
Comment 12 Ariel Garcia CLA 2008-02-20 12:04:29 EST
Nick, please look at the Bug #219594 which i now marked as duplicate of this one, it reports about the same NPE happening when refreshing the GlueInfoViewer, suggesting that perhaps some code can be merged.
Comment 13 Nick Tsioutsias CLA 2008-02-20 12:12:46 EST
The code is already merged with the new patches
Comment 14 Mathias Stümpert CLA 2008-02-21 03:33:43 EST
Now we got it. Patch applied and committed, exception gone. At least for me it is fixed now.
Comment 15 Nick Tsioutsias CLA 2008-02-21 03:42:53 EST
I am marking it as fixed then
Comment 16 Ariel Garcia CLA 2008-05-18 11:20:18 EDT
Closing
Comment 17 Ariel Garcia CLA 2009-05-03 10:34:29 EDT
Comment on attachment 90191 [details]
Patch for eu.geclipse.info

Applied by Mathias