Bug 217076 - [Apply Patch] Show which context lines has been applied with a fuzz factor
Summary: [Apply Patch] Show which context lines has been applied with a fuzz factor
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact: Pawel Pogorzelski CLA
URL: http://polishineclipse.blogspot.com/2...
Whiteboard: stalebug
Keywords:
Depends on: 205761 217073
Blocks: 196228
  Show dependency tree
 
Reported: 2008-01-30 06:50 EST by Tomasz Zarna CLA
Modified: 2021-11-05 01:42 EDT (History)
1 user (show)

See Also:


Attachments
Mockup (37.94 KB, image/png)
2008-02-29 10:00 EST, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2008-01-30 06:50:34 EST
In the Apply Patch wizard show which context lines has been applied with a fuzz factor. An idea is to add and color "diff lines" for such context lines. I would use a low distractive color like yellow.
Comment 1 Tomasz Zarna CLA 2008-02-29 10:00:26 EST
Created attachment 91185 [details]
Mockup

Mockup showing how this could look like. Yellow regions are the ones applied using the fuzz factor. Gray regions are not part of the hunk.

I'm wondering if thers is a situation when used fuzz factor is greater then 1 but only one line of context doesn't match shouldn't we indicate it somehow? In other words, shouldn't we show that actually more then 1 line have been ignored? Shoudn't they be part of a "yellow region" too? If yes, in the attached mockup, line [8] would also be marked yellow, even though it perfectly matches with the content of the patch (hunk).
Comment 2 Tomasz Zarna CLA 2008-04-15 08:54:07 EDT
I'm afraid I won't make it in 3.4 M7, which is in fact the last iteration for 3.4. Thus I'm moving it to 3.5.
Comment 3 Szymon Brandys CLA 2009-03-06 06:11:57 EST
We haven't investigated the issue during 3.5 and we don't plan to address it now. I'm removing the target milestone but we'll set more realistic one when we have feedback from anyone interested in fixing this.
Comment 4 Tomasz Zarna CLA 2009-07-14 08:32:38 EDT
Taken from bug 217076, comment 2:
> (...) it would be good to show a warning in cases where none of the context lines is
> actually used when the patch is applied.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:13:32 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 6 Eclipse Genie CLA 2021-11-05 01:42:03 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.