Bug 215647 - [About] Certificate slideout in About->Plugin dialog looks poor
Summary: [About] Certificate slideout in About->Plugin dialog looks poor
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Susan McCourt CLA
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2008-01-17 09:00 EST by Kim Horne CLA
Modified: 2014-03-27 06:08 EDT (History)
5 users (show)

See Also:


Attachments
Table tree with inline table (rough photoshop) (222.84 KB, image/jpeg)
2008-01-17 09:52 EST, Kim Horne CLA
no flags Details
Table tree with inline text (rough photoshop) (210.02 KB, image/jpeg)
2008-01-17 09:54 EST, Kim Horne CLA
no flags Details
comp using grid (15.27 KB, image/x-png)
2008-01-17 11:47 EST, Chris Gross CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kim Horne CLA 2008-01-17 09:00:07 EST
The certificate slideout in this dialog looks quite bad.  In fact, it's borderline eyesore. 

We can do better here.  It'd be nice if we could keep it as a slideout (we dont have many examples of this feature in the workbench) but I realize it may be better served by a separate dialog.  I will attach a screenshot of another neat idea - it'd require a good deal of work and some custom SWT controls but it'd be fun to implement.
Comment 1 Kim Horne CLA 2008-01-17 09:52:50 EST
Created attachment 87156 [details]
Table tree with inline table (rough photoshop)
Comment 2 Kim Horne CLA 2008-01-17 09:54:14 EST
Created attachment 87158 [details]
Table tree with inline text (rough photoshop)
Comment 3 Thomas Schindl CLA 2008-01-17 09:59:04 EST
I'm curiose how you plan to implement this :-)
Comment 4 Kim Horne CLA 2008-01-17 11:19:30 EST
(In reply to comment #3)
> I'm curiose how you plan to implement this :-)
> 

I don't plan to implement anything. ;)
Comment 5 Chris Gross CLA 2008-01-17 11:38:29 EST
Well it could be implemented by using Grid.  Each cert would be a child row of the plugin row.  The child row would have to use column spanning and a custom renderer.  Not that I'm volunteering ;)
Comment 6 Chris Gross CLA 2008-01-17 11:47:48 EST
Created attachment 87168 [details]
comp using grid

Actually, one second thought if I were using Grid on this, I would do something like this comp.  Essentially use Grid's column grouping feature.  Its essentially designed for this kinda problem.
Comment 7 Kim Horne CLA 2008-01-17 13:11:59 EST
(In reply to comment #6)
> Created an attachment (id=87168) [details]
> comp using grid
> 
> Actually, one second thought if I were using Grid on this, I would do something
> like this comp.  Essentially use Grid's column grouping feature.  Its
> essentially designed for this kinda problem.  
> 

That looks pretty cool actually.  The issue I see is that resolving the certificate properties for a given plugin is expensive.  If you want to show those properties in the table you'd need to fetch them for every visible plug-in, which would take a very long time.
Comment 8 Chris Gross CLA 2008-01-17 15:11:26 EST
True.  I guess it could be done in a worker thread or something.  
Comment 9 Kim Horne CLA 2008-01-18 14:32:06 EST
(In reply to comment #8)
> True.  I guess it could be done in a worker thread or something.  
> 

Y'know, we're already determinign the signed state via background jobs.  I wonder if all of the data is parsed already when determining that state.  If it is, we could just tweak the update job to update the content as well as the label (the signed/unsigned image)
Comment 10 Lars Vogel CLA 2014-03-27 06:08:01 EDT
Presentation has changed a while, marking as WORKFORME.