Bug 215071 - report as Bug should include subentries too
Summary: report as Bug should include subentries too
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Willian Mitsuda CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2008-01-11 14:18 EST by Willian Mitsuda CLA
Modified: 2008-10-30 01:12 EDT (History)
1 user (show)

See Also:


Attachments
Patch (2.83 KB, patch)
2008-01-21 15:19 EST, Willian Mitsuda CLA
no flags Details | Diff
mylyn/context/zip (13.03 KB, application/octet-stream)
2008-01-21 15:19 EST, Willian Mitsuda CLA
no flags Details
Error log with 3 levels for testing purposes (4.70 KB, text/plain)
2008-01-25 16:01 EST, Willian Mitsuda CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Willian Mitsuda CLA 2008-01-11 14:18:10 EST
Sometimes entries in the error log as made by an entry with a simple message, and many subentries with more detailed stack traces, etc.

The report as bug action should include the subentries too, if you invoke it from a top-level entry.

Actually it is hard to report if you have many subentries because you would have to manually copy each of them.
Comment 1 Steffen Pingel CLA 2008-01-11 16:22:21 EST
That sounds like a great idea. Would you be interested in providing a patch Willian?
Comment 2 Willian Mitsuda CLA 2008-01-21 15:19:10 EST
Created attachment 87439 [details]
Patch

It asks the user to include subentries if it has any.

I did manual tests using a 3 level log entry creating a local task.

BTW, I found it strange that the class NewTaskFromErrorAction is in mylyn.bugzilla.ide project, since it is a generic functionality. The first place I tried was in mylyn.pde.ui.
Comment 3 Willian Mitsuda CLA 2008-01-21 15:19:13 EST
Created attachment 87440 [details]
mylyn/context/zip
Comment 4 Mik Kersten CLA 2008-01-22 23:49:02 EST
Thanks Willian!  Patch applied, but not yet verified because I didn't have a log entry with subentries around (left a note in the New & Noteworthy to review the UI).  I changed the text to "Include children of this entry in the report?" since I'm not sure if the word "subentry" is commonly recognized.  Regarding the location of this class, yes, everything in the current ..mylyn.bugzilla.ide plug-in is a candidate to be moved for 3.0, added note to: http://wiki.eclipse.org/Mylyn_Porting_Guide#Pending_Changes_for_Mylyn_3.0
Comment 5 Eugene Kuleshov CLA 2008-01-23 00:14:04 EST
Is all logs put into the description text? I am bit concerned that it would make it too long and in result less readable.

Maybe such large logs should be posted as attachments, and then provide a convenience feature to open log in the Error Log view, which allows to import logs for browsing (though I am not sure if these actions are public api).
Comment 6 Willian Mitsuda CLA 2008-01-25 16:01:04 EST
Created attachment 87913 [details]
Error log with 3 levels for testing purposes

If anyone want to test, just import this file into error log.
Comment 7 Willian Mitsuda CLA 2008-01-25 16:22:04 EST
 (In reply to comment #5)
> Is all logs put into the description text? I am bit concerned that it would make
> it too long and in result less readable.
> 
> Maybe such large logs should be posted as attachments, and then provide a
> convenience feature to open log in the Error Log view, which allows to import
> logs for browsing (though I am not sure if these actions are public api).

I like this idea. I opened bug#216640 and bug#216642.

I didn't open a bug for the attachment -> error log visualization yet, because I think it is better to have the attachment story completed first. But I wonder how to make this kind of automatic? Maybe attach error log entries using a custom mime-type would be the best approach?