Bug 212314 - DebugModelPropertyTester does not use the IDebugModelProvider adapter.
Summary: DebugModelPropertyTester does not use the IDebugModelProvider adapter.
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-12-07 19:29 EST by Pawel Piech CLA
Modified: 2007-12-19 11:20 EST (History)
1 user (show)

See Also:

Attachments
Patch with fix. (2.07 KB, patch)
2007-12-07 19:29 EST, Pawel Piech CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2007-12-07 19:29:48 EST 
Created attachment 84793 [details]
Patch with fix.

This tester should be extended to support non standard debug model elements.

I'm attaching a patch with a fix.  The patch also adds the ability for the tester to check if no debug context is active, using a test with an empty value:
    <test property="org.eclipse.debug.ui.getModelIdentifier" value=""/>
Comment 1 Darin Wright CLA 2007-12-17 15:31:46 EST 
Applied patch. Modified to use IAdapterManager.getAdapter(...) rather than relying on instanceof IAdaptable.
Comment 2 Darin Wright CLA 2007-12-17 15:32:04 EST 
Please verify, Mike.
Comment 3 Michael Rennie CLA 2007-12-19 11:20:34 EST 
verified