Bug 210320 - group working sets by task repository in working set edit dialog
Summary: group working sets by task repository in working set edit dialog
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2007-11-19 21:02 EST by Mik Kersten CLA
Modified: 2007-11-27 17:13 EST (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (8.88 KB, application/octet-stream)
2007-11-19 22:19 EST, Mik Kersten CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mik Kersten CLA 2007-11-19 21:02:46 EST 
When a significant number of task repositories and queries are present, it can be cumbersome to select Mylyn's task working set contents.  Grouping by task repository will facilitate this.
Comment 1 Eugene Kuleshov CLA 2007-11-19 21:31:25 EST 
Did you actually meant "working set edit" dialog?
Comment 2 Mik Kersten CLA 2007-11-19 22:19:18 EST 
Done for both tasks and resources. 

 (In reply to comment #1)
> Did you actually meant "working set edit" dialog?

Yes.
Comment 3 Mik Kersten CLA 2007-11-19 22:19:20 EST 
Created attachment 83296 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2007-11-20 18:20:59 EST 
My workbench stalled when I tried to open the edit dialog for a working set. It was caused by the Subclipse Mylyn integration trying to determine the project / repository associations (bug 200220).
Comment 5 Eugene Kuleshov CLA 2007-11-20 19:02:37 EST 
(In reply to comment #4)
> It was caused by the Subclipse Mylyn integration trying to determine the project /
> repository associations (bug 200220).

Mark said that he did something to fix that, so I was holding off with implementing a preference to disable this feature in Subclipse Mylyn integration.
Comment 6 Mark Phippard CLA 2007-11-20 19:27:20 EST 
The change I made only exists in the 1.3.x developer releases.  What I did was remove a check we had in our code to determine if a resource was managed by SVN.  This check would trigger Eclipse to refresh the resources if they were out of synch.  It is this refresh, and all of the things that triggers (builders etc.) that was causing the slowdown.
Comment 7 Eugene Kuleshov CLA 2007-11-20 19:56:26 EST 
Mark, it seem it would be a good idea to implement that setting and release Mylyn plugin for 1.2.x stream...
Comment 8 Mark Phippard CLA 2007-11-20 19:59:33 EST 
The change was in Subclipse itself though.  I am still not really sure about the setting.  If you want to do it, I guess go ahead.  I just do not think most people would want to give up the features it provides, such as hyperlinking in the history view.

The core problem should be fixed, I think people can wait a couple of months to get it.
Comment 9 Steffen Pingel CLA 2007-11-21 17:46:52 EST 
Thanks for the insight Mark. This definitely needs to be addressed on the Mylyn side to guard against performance problems with older Subclipse releases. Can we add a timeout that skips the lookup if it takes longer than n seconds?
Comment 10 Eugene Kuleshov CLA 2007-11-21 18:15:00 EST 
Steffen, I think that is in scope of bug 200220
Comment 11 Mik Kersten CLA 2007-11-27 17:13:12 EST 
This is done now.