Bug 210121 - Please add support for Win64 on Itanium in org.eclipse.core.filesystem and org.eclipse.core.resources.win32
Summary: Please add support for Win64 on Itanium in org.eclipse.core.filesystem and or...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 142495
  Show dependency tree
 
Reported: 2007-11-16 12:13 EST by Oleg Krasilnikov CLA
Modified: 2007-12-12 05:39 EST (History)
2 users (show)

See Also:


Attachments
Binaries and scripts for Win64 support on Itanium (98.29 KB, application/octet-stream)
2007-11-16 12:13 EST, Oleg Krasilnikov CLA
no flags Details
The update for core.map (1.50 KB, patch)
2007-11-21 15:50 EST, Szymon Brandys CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Krasilnikov CLA 2007-11-16 12:13:20 EST
Created attachment 83086 [details]
Binaries and scripts for Win64 support on Itanium

Support for 64-bit Windows on Itanium is planned soon.

SWT and some other plugins (affected by this change) already have support for
this platform. We need to have resource-related dlls for IA64 also.

I've attached an archive with corresponding files:

Dlls compiled for Itanium:
org.eclipse.core.resources.win32\os\win32\ia64\win32refresh.dll 
org.eclipse.core.filesystem.win32.ia64\os\win32\ia64\localfile_1_0_0.dll 

Scripts used to build these dlls:
org.eclipse.core.resources.win32\a\make_ia64.bat 
org.eclipse.core.filesystem\natives\win32\make_IA64.bat 

I'm using cross-compiler from Windows Software Development Kit (SDK) for
Windows Vista v 6.01.

Could you please create corresponding items in CVS ?

Is it possible to compile Itanium versions on your side, or should I send
updates for binary files in future (it's rare for these dlls, but...)?

Thanks in advance.
Comment 1 John Arthorne CLA 2007-11-16 16:00:46 EST
Are there any changes to the C source code, or did you just recompile them on the new architecture? Is it unavoidable that the DLL files are so much larger (nearly 4x larger than 32-bit version)? 

As you say, these natives rarely change, but when they do we appreciate help from the community to contribute updates and to help with testing. We are a very small team on resources and it's difficult to cover all the platform/os combinations ourselves.
Comment 2 Oleg Krasilnikov CLA 2007-11-17 05:16:30 EST
John,

changes in source code were not required. Just recompile.

What about binaries size, it's known thing for IA64 code. 
I don't know whether it's compiler feature, or Itanium
binary code cannot be smaller in principle. 


Regarding testing, I'm ready to take part in any time.
Comment 3 Oleg Krasilnikov CLA 2007-11-21 10:46:42 EST
Any update ?
It would be nice to have mentioned files in CVS soon.
Thanks.
Comment 4 Szymon Brandys CLA 2007-11-21 10:56:29 EST
It is in progress. See bug 210386.
Comment 5 John Arthorne CLA 2007-11-21 12:04:55 EST
The bundles have been created in CVS, and I have released the native DLLs from Oleg's patch (thanks!). I have also refactored the resources natives so that the source code is stored in the host plugin (org.eclipse.core.resources), and the fragments just contain the native DLL and the extension in fragment.xml. This was needed to avoid duplicating the code in multiple fragments (or shipping both versions of the DLL in the same fragment). This needs some more testing on both x86 and ia64.
Comment 6 Kim Moir CLA 2007-11-21 15:32:57 EST
Is org.eclipse.core.resources.win32.x86 ready to be included in the platform feature? I was going to run a test build for the source build changes.
Comment 7 John Arthorne CLA 2007-11-21 15:46:45 EST
Kim: No. I released everything into CVS in the new bundle, but it's completely untested. Szymon is going to look at it tomorrow, and will let you know when ready for a build.
Comment 8 Szymon Brandys CLA 2007-11-21 15:50:47 EST
Created attachment 83471 [details]
The update for core.map
Comment 9 Szymon Brandys CLA 2007-11-22 06:35:14 EST
The N20071122-0010 build contains new and renamed fragments. The tests on Win XP has passed on my machine.

Oleg, when the next I-build is produced, please verify that it works on ia64.
Of course you can try the current N-build as well.

Comment 10 Oleg Krasilnikov CLA 2007-11-22 06:38:22 EST
Thanks, Szymon.
Comment 11 Szymon Brandys CLA 2007-12-03 03:17:23 EST
Oleg, did you verify that it works on ia64? Please add a comment so I could mark it FIXED.
Comment 12 Oleg Krasilnikov CLA 2007-12-03 09:01:16 EST
Szymon,
you can see that your patch is applied in the latest CVS.
Unfortunately, there are some problems with build for IA64.
When they will be resolved, all related bugs will be closed.
 
Comment 13 Szymon Brandys CLA 2007-12-03 10:35:49 EST
(In reply to comment #12)
> Unfortunately, there are some problems with build for IA64.
> When they will be resolved, all related bugs will be closed.

Are you referring to any particular bug in the bugzilla?

Comment 14 Oleg Krasilnikov CLA 2007-12-03 10:52:53 EST
The whole work is tracked by bug #142495:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=142495
Comment 15 Szymon Brandys CLA 2007-12-10 13:27:30 EST
Released to HEAD (see comment #5).
Comment 16 Szymon Brandys CLA 2007-12-12 05:39:31 EST
Verified.