Bug 209572 - InputAttachmentSourcePage has amnesia
Summary: InputAttachmentSourcePage has amnesia
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.2   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2007-11-12 17:52 EST by Chris Aniszczyk CLA
Modified: 2007-11-26 17:31 EST (History)
1 user (show)

See Also:


Attachments
org.eclipse.mylyn.tasks.ui.patch (39.20 KB, patch)
2007-11-23 23:36 EST, Chris Aniszczyk CLA
no flags Details | Diff
mylyn/context/zip (1.10 KB, application/octet-stream)
2007-11-23 23:36 EST, Chris Aniszczyk CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-11-12 17:52:30 EST
Everytime you go to specify an attachment, it defaults to file. 

In my case, I use the clipboard about 99.9% of the time so it's annoying to have to change this all the time. The InputAttachmentSourcePage should use dialog settings to store the last selection so alleviate the pain of users.
Comment 1 Steffen Pingel CLA 2007-11-13 20:56:43 EST
+1 I have the same usage pattern. The dialog should at least detect if there is anything in the clipboard and select the clipboard by default in that case.
Comment 2 Mik Kersten CLA 2007-11-14 23:16:03 EST
+1 for last selection.
Comment 3 Chris Aniszczyk CLA 2007-11-23 15:23:40 EST
I'm going to do this one on my 20+ hour plane ride today.
Comment 4 Mik Kersten CLA 2007-11-23 15:54:00 EST
Excellent.  Post if you have any questions.
Comment 5 Chris Aniszczyk CLA 2007-11-23 23:36:55 EST
Created attachment 83686 [details]
org.eclipse.mylyn.tasks.ui.patch

Here's a patch to implement the "last selection" logic for dialog settings and remove amnesia from the wizard. I also cleaned up the code a bit.
Comment 6 Chris Aniszczyk CLA 2007-11-23 23:36:58 EST
Created attachment 83687 [details]
mylyn/context/zip
Comment 7 Eugene Kuleshov CLA 2007-11-24 00:55:04 EST
Chris, while you are on it, would it be interesting for you to implement a history dropdown for the file name in this dialog? It could remember last 10 files entered there and it can be saved in the dialog preferences. Such functionality is available in some Platform wizard, for example, location page in CVS checkout wizard.
Comment 8 Chris Aniszczyk CLA 2007-11-24 17:04:43 EST
One step at a time Eugene, I don't like big patches :P

We can open another bug for that case, which in my opinion, file based attachments is probably not used that much versus the clipboard (just my hunch/opinion)
Comment 9 Eugene Kuleshov CLA 2007-11-24 17:58:39 EST
 (In reply to comment #8)
> One step at a time Eugene, I don't like big patches :P

true true

> We can open another bug for that case, which in my opinion, file based
> attachments is probably not used that much versus the clipboard (just my
> hunch/opinion)

I am using it when I need to include reply to someone's comment into the description of the patch (have to copy two different things into clipboard), but I guess it because task editor does not provide reach experience when working with attachments (it is just a submission wizard on top of the web UI).
Comment 10 Steffen Pingel CLA 2007-11-26 13:20:58 EST
Thanks for the patch Chris! I'll take a look at it so we can get this in for the next release.
Comment 11 Steffen Pingel CLA 2007-11-26 17:31:26 EST
Great patch, thank you for doing the cleanup. Updated IP log and applied patch with a minor modification: when the wizard settings did not exist the next button would be enabled although no filename was entered.