Community
Participate
Working Groups
Build ID: M20070212-1330 Steps To Reproduce: 1. Go to an empty workspace 2. Open an editor (not associated with a project) 3. new ContainerSelectionDialog(...) since there are no projects available, the OK button should be disabled. More information:
(In reply to comment #0) > 2. Open an editor (not associated with a project) > 3. new ContainerSelectionDialog(...) since there are no projects available, the > OK button should be disabled. I don't fully understand these two steps. How are you opening an editor? Through File > Open...? That just opens a file in Eclipse, no dialog appears except for the operating system's file selection dialog.
I believe this goes to Tod as an IDE/Dialog bug.
Created attachment 87361 [details] Patch to disable the 'OK' button if there are no containers to select.
This patch is out of date and needs to be refreshed to HEAD
This patch does actually compile against HEAD but it has an error in it. On top of that I am not sure where this case shows up - we will need better steps.
Created attachment 89060 [details] Corrected patch that compiles properly. (In reply to comment #5) > On top of that I am not sure where this case shows up - we will need better > steps. I don't understand the scenario given by comment 0, but here is one way to get the dialog up. 1. Start Eclipse pointing at an empty/non-existent folder for the workspace. 2. File > Import > File System 3. Click the 'Browse' button. 4. See that there are no projects / folders available, but the 'OK' button is enabled.
This should not be enabled until a selection is made. We would need to add API to ContainerSelectionGroup to listen for selection to do this fix propertly.
(In reply to comment #7) > This should not be enabled until a selection is made. We would need to add API > to ContainerSelectionGroup to listen for selection to do this fix propertly. Should we be tagging this as "api" since ContainerSelectionGroup is actually an internal class? Also, the listener portion is already embedded in ContainerSelectionDialog's createDialogArea(Composite) method. I haven't debugged it through yet, but the dialog seems to be initialized with a selection right from the get-go, which I presume is causing getOkButton().setEnabled(true) to be called, thus, enabling the button if at least one project is available in the workspace.
right you are Remy
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
