Bug 20921 - [ExternalTools] Project properties runs autobuild for all projects
Summary: [ExternalTools] Project properties runs autobuild for all projects
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: 2.1 M4   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks:
 
Reported: 2002-06-24 16:44 EDT by Adam Schlegel CLA
Modified: 2002-12-03 14:36 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Schlegel CLA 2002-06-24 16:44:12 EDT
Build 20020624

When you hit OK on a project's property page, the autobuild runs for all
projects. If there are errors in External Tool Builders for other projects, this
can cause a dialog to pop up telling the user that the build has failed, even if
the current project built sucessfully.

To reproduce (a particularly annoying case):
1) Create 2 java projects - Foo and Bar
2) From Foo's External Tool Builders property page, create a new builder that is
pointed to the .project file. Exit the page, and click OK when the error dialog
opens (.project is not a working External Tool)
3) Open the properties page for Bar and hit OK immediately.
4) The same error dialog opens complaining about an External Tool Internal Error
(for Foo), even though Bar has no External Tool builder defined.

Closing the project properties window should only rebuild the current project.
Comment 1 Nick Edgar CLA 2002-07-04 11:50:13 EDT
Did you make a change on the project properties page?
If not, no build should occur.

Comment 2 Adam Schlegel CLA 2002-07-04 12:46:54 EDT
You do not need to make a change to Bar's property page for it to complain 
about the broken External Tool builder.

There are 2 problems here:
1) The external tool builders are running when there are no changes made to the 
property page.
2) The external tool builders for other projects are running when changes are 
made to a project's property page.
Comment 3 Tod Creasey CLA 2002-08-09 15:38:05 EDT
External Tools issue.
Comment 4 Simon Arsenault CLA 2002-09-06 15:26:00 EDT
Waiting for Core to provide support on this.
Comment 5 Darin Wright CLA 2002-11-15 12:06:04 EST
Needs investigation.
Comment 6 Jared Burns CLA 2002-11-27 11:51:28 EST
My understanding of the problem here is that the core runs a build whenever
files are changed in the workspace. Editing the project builders writes data
to the .project file and now to the .externalToolBuilders directory.
Comment 7 John Arthorne CLA 2002-12-02 10:14:29 EST
Adam's problem #2 is covered by bug 21029.  However, this doesn't alter the fact
that no changes should happen if the user does not modify anything in the
properties page (Adam's problem #1).
Comment 8 Darin Swanson CLA 2002-12-02 18:33:16 EST
The BuilderPropertyPage nows does verification on ok to check that anything has 
changed.
Please verify (Jared).
Comment 9 Jared Burns CLA 2002-12-03 14:36:57 EST
Verified code.